Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1528241

Re: [PATCH 01/10] perf, tools: Factor out scale conversion code

Show all headers | View raw

On Fri, Nov 18, 2016 at 04:36:11PM -0800, Andi Kleen wrote:

SNIP

>  	return ret;
> @@ -261,6 +267,12 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
>  	alias->long_desc = long_desc ? strdup(long_desc) :
>  				desc ? strdup(desc) : NULL;
>  	alias->topic = topic ? strdup(topic) : NULL;
> +	if (unit) {
> +		if (convert_scale(unit, &unit, &alias->scale) < 0)
> +			return -1;
> +		snprintf(alias->unit, sizeof(alias->unit), "%s", unit);
> +	}
> +	alias->str = strdup(val);

  CC       util/pmu.o
util/pmu.c: In function ‘__perf_pmu__new_alias’:
util/pmu.c:270:6: error: ‘unit’ undeclared (first use in this function)
  if (unit) {


jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Support Intel uncore event lists in perf Andi Kleen <andi@firstfloor.org> - 2016-11-19 01:40 +0100
  [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen <andi@firstfloor.org> - 2016-11-19 01:40 +0100
    Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Jiri Olsa <jolsa@redhat.com> - 2016-11-23 10:30 +0100
    Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Jiri Olsa <jolsa@redhat.com> - 2016-11-23 10:50 +0100
  [PATCH 10/10] perf, tools, stat: Output generic dividedby metric Andi Kleen <andi@firstfloor.org> - 2016-11-19 01:40 +0100
  [PATCH 06/10] perf, tools: Add debug support for outputing alias string Andi Kleen <andi@firstfloor.org> - 2016-11-19 01:40 +0100
  [PATCH 02/10] perf, tools: Parse eventcode as number in jevents Andi Kleen <andi@firstfloor.org> - 2016-11-19 01:40 +0100
    Re: [PATCH 02/10] perf, tools: Parse eventcode as number in jevents Jiri Olsa <jolsa@redhat.com> - 2016-11-23 10:50 +0100

csiph-web