Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1527174
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of odroid-xu3/4 |
| Date | 2016-11-22 02:30 +0100 |
| Message-ID | <sG84h-rl-3@gated-at.bofh.it> (permalink) |
| References | <sFR3s-6w0-7@gated-at.bofh.it> <sG84h-rl-5@gated-at.bofh.it> <sG0gp-41g-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/22/2016 02:06 AM, Krzysztof Kozlowski wrote:
> On Mon, Nov 21, 2016 at 04:10:32PM +0900, Jaehoon Chung wrote:
>> Odroid-xu3/4 didn't need to use the cd-gpios for detecting card.
>> Because Host controller has the CDETECT register through SDx_CDN line.
>> Host controller can know whether card is inserted or not with this
>> register.
>>
>> When i have checked the Odroid-xu3/4, they are using CDETECT register.
>> (Not using exteranl cd-gpio.)
>
> Makes sense. Just one question: the sd0_cd pinctrl setting should stay,
> right?
Right, It needs to use SD0_CD function.
I have tested on Odroid-XU3/XU4.
Tested with the below cases.
1) On boot with SD-card (without eMMC)
- Inserted eMMC : Detected
- Removed eMMC : Detected
2) On boot with Sd-card (with eMMC)
- Detected
3) On boot with eMMC
- Detected
Best Regards,
Jaehoon Chung
>
> Best regards,
> Krzysztof
>
>> Fixes: fb1aeedb61ad ("ARM: dts: add mmc detect gpio for exynos5422-odroidxu3")
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 9e63328..05b9afdd 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -510,7 +510,6 @@
>> &mmc_0 {
>> status = "okay";
>> mmc-pwrseq = <&emmc_pwrseq>;
>> - cd-gpios = <&gpc0 2 GPIO_ACTIVE_LOW>;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <0 4>;
>> --
>> 2.10.1
>>
>
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of odroid-xu3/4 Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-21 08:20 +0100
Re: [PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of odroid-xu3/4 Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-21 18:10 +0100
Re: [PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of odroid-xu3/4 Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-22 02:30 +0100
Re: [PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of odroid-xu3/4 Andrzej Hajda <a.hajda@samsung.com> - 2016-11-22 09:00 +0100
Re: [PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of odroid-xu3/4 Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-22 09:20 +0100
Re: [PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of odroid-xu3/4 Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-23 18:30 +0100
csiph-web