RE: [char-misc-next 4/4 V2] mei: bus: enable non-blocking RX

From	"Winkler, Tomas" <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	RE: [char-misc-next 4/4 V2] mei: bus: enable non-blocking RX
Date	2016-11-19 17:20 +0100
Message-ID	<sFgwW-7gR-29@gated-at.bofh.it> (permalink)
References	<sFc0h-4hw-3@gated-at.bofh.it> <sFcMG-4Qx-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> 
> On Sat, Nov 19, 2016 at 02:16:11PM +0200, Tomas Winkler wrote:
> > From: Alexander Usyskin <alexander.usyskin@intel.com>
> >
> > Enable non-blocking receive for drivers on mei bus, this allows
> > checking for data availability by mei client drivers. This is most
> > effective for fixed address clients, that lacks flow control.
> >
> > This function adds new API function mei_cldev_recv_nonblock(), it
> > retuns -EGAIN if function will block.
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > ---
> > V2: use _nonblock() function suffix instead of NONBLOCK flag
> >
> >  drivers/misc/mei/bus-fixup.c |  4 ++--
> >  drivers/misc/mei/bus.c       | 31 +++++++++++++++++++++++++++++--
> >  drivers/misc/mei/mei_dev.h   |  7 ++++++-
> >  include/linux/mei_cl_bus.h   |  6 ++++--
> >  4 files changed, 41 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/misc/mei/bus-fixup.c
> > b/drivers/misc/mei/bus-fixup.c index 7f2cef9011ae..18e05ca7584f 100644
> > --- a/drivers/misc/mei/bus-fixup.c
> > +++ b/drivers/misc/mei/bus-fixup.c
> > @@ -141,7 +141,7 @@ static int mei_osver(struct mei_cl_device *cldev)
> >  	if (ret < 0)
> >  		return ret;
> >
> > -	ret = __mei_cl_recv(cldev->cl, buf, length);
> > +	ret = __mei_cl_recv(cldev->cl, buf, length, 0);
> 
> What is 0 here?  Again, mode...

Yes,  it means no change in behavior,  but this is an internal function.

Thanks
Tomas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[char-misc-next 4/4 V2] mei: bus: enable non-blocking RX Tomas Winkler <tomas.winkler@intel.com> - 2016-11-19 12:30 +0100
  Re: [char-misc-next 4/4 V2] mei: bus: enable non-blocking RX Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-19 13:20 +0100
    RE: [char-misc-next 4/4 V2] mei: bus: enable non-blocking RX "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-11-19 17:20 +0100

csiph-web