Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1526836
| From | Dmitry Vyukov <dvyukov@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking |
| Date | 2016-11-21 17:00 +0100 |
| Message-ID | <sFZaF-333-15@gated-at.bofh.it> (permalink) |
| References | <sEclH-5WJ-3@gated-at.bofh.it> <sEclH-5WJ-9@gated-at.bofh.it> <sFZaF-333-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Nov 21, 2016 at 4:54 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 16 Nov 2016 17:37:01 +0000
> alexander.levin@verizon.com wrote:
>
>> This is a simple way to be able to verify syscall parameters before the
>> call to the actual syscall, and also verify the return value after the
>> call.
>>
>> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
>> ---
>> include/linux/syscalls.h | 7 ++++++-
>> kernel/Makefile | 2 ++
>> kernel/abi_spec.c | 15 +++++++++++++++
>> 3 files changed, 23 insertions(+), 1 deletion(-)
>> create mode 100644 kernel/abi_spec.c
>>
>> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
>> index 91a740f..6aa3228 100644
>> --- a/include/linux/syscalls.h
>> +++ b/include/linux/syscalls.h
>> @@ -79,6 +79,7 @@ union bpf_attr;
>> #include <linux/quota.h>
>> #include <linux/key.h>
>> #include <trace/syscall.h>
>> +#include <linux/abi_spec.h>
>>
>> /*
>> * __MAP - apply a macro to syscall arguments
>> @@ -192,13 +193,17 @@ extern struct trace_event_functions exit_syscall_print_funcs;
>>
>> #define __PROTECT(...) asmlinkage_protect(__VA_ARGS__)
>> #define __SYSCALL_DEFINEx(x, name, ...) \
>> + extern const struct syscall_spec syscall_spec##name; \
>> asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \
>> __attribute__((alias(__stringify(SyS##name)))); \
>> static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__)); \
>> asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)); \
>> asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \
>> { \
>> - long ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \
>> + long ret; \
>> + abispec_check_pre(&syscall_spec##name, __MAP(x,__SC_CAST,__VA_ARGS__)); \
>> + ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \
>> + abispec_check_post(&syscall_spec##name, ret, __MAP(x,__SC_CAST,__VA_ARGS__)); \
>
> Do you want this for DEFINE0() too? Or does this not care about system
> calls with no arguments?
This should care about syscalls without args:
- we still may want to check return values
- something like debug tracing would like to print them
- there may also be some side effects (or absence of side effects)
that we may want to check
>> __MAP(x,__SC_TEST,__VA_ARGS__); \
>> __PROTECT(x, ret,__MAP(x,__SC_ARGS,__VA_ARGS__)); \
>> return ret; \
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC 0/3] ABI spec - verification alexander.levin@verizon.com - 2016-11-16 18:40 +0100
[RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking alexander.levin@verizon.com - 2016-11-16 18:40 +0100
Re: [RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking Dmitry Vyukov <dvyukov@google.com> - 2016-11-21 17:00 +0100
Re: [RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking alexander.levin@verizon.com - 2016-11-23 16:20 +0100
Re: [RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking Steven Rostedt <rostedt@goodmis.org> - 2016-11-21 17:00 +0100
[RFC 1/3] abi_spec: basic definitions of constraints, args and syscalls alexander.levin@verizon.com - 2016-11-16 18:40 +0100
Re: [RFC 1/3] abi_spec: basic definitions of constraints, args and syscalls Dmitry Vyukov <dvyukov@google.com> - 2016-11-21 15:50 +0100
Re: [RFC 1/3] abi_spec: basic definitions of constraints, args and syscalls alexander.levin@verizon.com - 2016-11-23 16:10 +0100
Re: [RFC 1/3] abi_spec: basic definitions of constraints, args and syscalls Steven Rostedt <rostedt@goodmis.org> - 2016-11-21 16:50 +0100
Re: [RFC 1/3] abi_spec: basic definitions of constraints, args and syscalls alexander.levin@verizon.com - 2016-11-23 16:20 +0100
Re: [RFC 1/3] abi_spec: basic definitions of constraints, args and syscalls Steven Rostedt <rostedt@goodmis.org> - 2016-11-23 16:40 +0100
Re: [RFC 1/3] abi_spec: basic definitions of constraints, args and syscalls Steven Rostedt <rostedt@goodmis.org> - 2016-11-23 16:40 +0100
[RFC 3/3] abi_spec: example spec for open(), placeholder for rest of syscalls alexander.levin@verizon.com - 2016-11-16 18:40 +0100
Re: [RFC 0/3] ABI spec - verification Thomas Gleixner <tglx@linutronix.de> - 2016-11-16 18:50 +0100
Re: [RFC 0/3] ABI spec - verification Dmitry Vyukov <dvyukov@google.com> - 2016-11-21 15:30 +0100
Re: [RFC 0/3] ABI spec - verification alexander.levin@verizon.com - 2016-11-23 15:40 +0100
csiph-web