Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1526738
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 2/3] kvm: svm: Add kvm_fast_pio_in support |
| Date | 2016-11-21 16:00 +0100 |
| Message-ID | <sFYeC-2u5-7@gated-at.bofh.it> (permalink) |
| References | <sFYeC-2u5-9@gated-at.bofh.it> <sFYeC-2u5-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 14/11/2016 23:15, Brijesh Singh wrote:
> + /* For size less than 4 we merge, else we zero extend */
> + val = (size < 4) ? kvm_register_read(vcpu, VCPU_REGS_RAX) : 0;
Are you sure it shouldn't always zero extend the high 32-bits? So "val"
should be declared as u32.
Paolo
> + ret = emulator_pio_in_emulated(&vcpu->arch.emulate_ctxt, size, port,
> + &val, 1);
> + if (ret) {
> + kvm_register_write(vcpu, VCPU_REGS_RAX, val);
> + return ret;
> + }
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH v1 2/3] kvm: svm: Add kvm_fast_pio_in support Paolo Bonzini <pbonzini@redhat.com> - 2016-11-21 16:00 +0100 Re: [PATCH v1 2/3] kvm: svm: Add kvm_fast_pio_in support Paolo Bonzini <pbonzini@redhat.com> - 2016-11-22 16:20 +0100
csiph-web