Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

From	John Garry <john.garry@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree
Date	2016-11-21 15:40 +0100
Message-ID	<sFXVf-2nj-17@gated-at.bofh.it> (permalink)
References	<sFhW1-7Z6-23@gated-at.bofh.it> <sFWmy-1in-11@gated-at.bofh.it> <sFWPv-1GV-19@gated-at.bofh.it> <sFXBT-2h6-7@gated-at.bofh.it> <sFXLz-2km-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 21/11/2016 14:25, Quentin Lambert wrote:
>
> On 11/21/2016 03:16 PM, John Garry wrote:
>> On 21/11/2016 13:20, Quentin Lambert wrote:
>>>
>>>
>>> On 11/21/2016 01:53 PM, John Garry wrote:
>>>> However I have noticed that we should do a call to hisi_sas_free() for
>>>> this failure, and later failures in the probe.
>>> I don't understand why, and would welcome the opportunity to learn
>>> something.
>>>
>>
>> We call hisi_sas_alloc() from hisi_sas_shost_alloc(); if we fail after
>> this in hisi_sas_probe(), then we should free the memmories and
>> workqueue got in hisi_sas_alloc(), which we don't.
> Thanks.
> Are you writing the patch or do you want me to do it?
>

We can do it, thanks.

> Quentin
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: hisi_sas: Add a missing call to kfree Quentin Lambert <lambert.quentin@gmail.com> - 2016-11-19 18:50 +0100
  Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree John Garry <john.garry@huawei.com> - 2016-11-21 14:00 +0100
    Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree Quentin Lambert <lambert.quentin@gmail.com> - 2016-11-21 14:30 +0100
      Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree John Garry <john.garry@huawei.com> - 2016-11-21 15:20 +0100
        Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree Quentin Lambert <lambert.quentin@gmail.com> - 2016-11-21 15:30 +0100
          Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree John Garry <john.garry@huawei.com> - 2016-11-21 15:40 +0100

csiph-web