Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits
Date	2016-11-21 13:00 +0100
Message-ID	<sFVqq-Fl-19@gated-at.bofh.it> (permalink)
References	<sEzih-48J-3@gated-at.bofh.it> <sEzih-48J-1@gated-at.bofh.it> <sFVqp-Fl-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Roger Quadros <rogerq@ti.com> writes:
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index f945380..6553903 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1656,6 +1656,9 @@ struct xhci_hcd {
>  #define XHCI_SSIC_PORT_UNUSED	(1 << 22)
>  #define XHCI_NO_64BIT_SUPPORT	(1 << 23)
>  #define XHCI_MISSING_CAS	(1 << 24)
> +/* For controller with a broken Port Disable implementation */
> +#define XHCI_BROKEN_PORT_PED	(1 << 21)

since back when I first wrote this, bit 21 has been taken. You should be
using bit 25 here.

-- 
balbi

Thread

[PATCH 1/3] usb: xhci: add quirk flag for broken PED bits Roger Quadros <rogerq@ti.com> - 2016-11-17 19:10 +0100
  Re: [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-11-18 11:50 +0100
    Re: [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits Roger Quadros <rogerq@ti.com> - 2016-11-21 13:00 +0100
  [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits Roger Quadros <rogerq@ti.com> - 2016-11-21 13:00 +0100
    Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits Felipe Balbi <balbi@kernel.org> - 2016-11-21 13:00 +0100
      Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits Roger Quadros <rogerq@ti.com> - 2016-11-21 14:10 +0100
    [PATCH v3 1/3] usb: xhci: add quirk flag for broken PED bits Roger Quadros <rogerq@ti.com> - 2016-11-21 14:10 +0100

csiph-web