Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1526553
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node |
| Date | 2016-11-21 11:50 +0100 |
| Message-ID | <sFUkF-8vE-11@gated-at.bofh.it> (permalink) |
| References | <sAZ1E-8eh-3@gated-at.bofh.it> <sAZ1E-8eh-13@gated-at.bofh.it> <sFMQ9-3uc-1@gated-at.bofh.it> <sFU1j-8p7-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Monday 21 November 2016 03:57 PM, Axel Haslam wrote:
> On Mon, Nov 21, 2016 at 3:42 AM, David Lechner <david@lechnology.com> wrote:
>> On 11/07/2016 02:39 PM, Axel Haslam wrote:
>>>
>>> This adds the ohci device node for the da850 soc.
>>> It also enables it for the omapl138 hawk board.
>>>
>>> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
>>> ---
>>> arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++
>>> arch/arm/boot/dts/da850.dtsi | 8 ++++++++
>>> 2 files changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/da850-lcdk.dts
>>> b/arch/arm/boot/dts/da850-lcdk.dts
>>> index 7b8ab21..aaf533e 100644
>>> --- a/arch/arm/boot/dts/da850-lcdk.dts
>>> +++ b/arch/arm/boot/dts/da850-lcdk.dts
>>> @@ -86,6 +86,14 @@
>>> };
>>> };
>>>
>>> +&usb_phy {
>>> + status = "okay";
>>> +};
>>> +
>>> +&ohci {
>>> + status = "okay";
>>> +};
>>> +
>>> &serial2 {
>>> pinctrl-names = "default";
>>> pinctrl-0 = <&serial2_rxtx_pins>;
>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>> index 2534aab..50e86da 100644
>>> --- a/arch/arm/boot/dts/da850.dtsi
>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>> @@ -405,6 +405,14 @@
>>> >;
>>> status = "disabled";
>>> };
>>> + ohci: usb@0225000 {
>>
>>
>> In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci
>> tree, the alias for the musb device is usb0. So, I think we should use usb1
>> here instead of ohci - or change the usb0 alias to musb.
>>
>> https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6
>
> ok, i will change to usb1, since i will be resubmiting this.
I have already applied a version of this patch. Please re-base against
linux-davinci/master and send a delta patch.
Thanks,
Sekhar
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node David Lechner <david@lechnology.com> - 2016-11-21 03:50 +0100
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node Axel Haslam <ahaslam@baylibre.com> - 2016-11-21 11:30 +0100
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node Sekhar Nori <nsekhar@ti.com> - 2016-11-21 11:50 +0100
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node Axel Haslam <ahaslam@baylibre.com> - 2016-11-21 12:00 +0100
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node Sekhar Nori <nsekhar@ti.com> - 2016-11-21 12:00 +0100
csiph-web