Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1526540
| From | Sylwester Nawrocki <s.nawrocki@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage |
| Date | 2016-11-21 11:40 +0100 |
| Message-ID | <sFUaZ-8sg-5@gated-at.bofh.it> (permalink) |
| References | <sFFYl-7E8-7@gated-at.bofh.it> <sFUaZ-8sg-7@gated-at.bofh.it> <sFFYl-7E8-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote: > MACH_SMDKC100, MACH_SMDKV210 and MACH_SMDKC110 are no longer supported > so we can drop the dead code. After this the driver no longer > differentiates between machines (S3C24xx machines are not supported by > it) so there is no need to override I2S device id in cpu_dai_name and > SEC_PLAYBACK dai_link can be removed as well. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > > Not tested. The driver did not override .platform_name which looks > suspicious to me. However I did not want to add changes which could have > some visible impact on output code. The patch looks good to me. However the existing smdk64xx sound support less so. I don't have smdk6410 set up for testing yet, possibly I get around that next week. Indeed it's strange .platform_name is not also "samsung-i2s.2". Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-20 20:30 +0100
Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-11-21 11:40 +0100
Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage Lars-Peter Clausen <lars@metafoo.de> - 2016-11-21 11:40 +0100
Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-11-21 12:30 +0100
Applied "ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-22 18:30 +0100
csiph-web