Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1526529
| From | Dmitry Vyukov <dvyukov@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2] infiniband: remove WARN that is not kernel bug |
| Date | 2016-11-21 11:20 +0100 |
| Message-ID | <sFTRE-8lZ-33@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
WARNINGs mean kernel bugs.
The one in ucma_write() points to user programming error
or a malicious attempt. This is not a kernel bug, remove it.
BUG/WARNs that are not kernel bugs hinder automated testing effots.
Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: syzkaller@googlegroups.com
---
Changes since v1:
- added printk_once
---
drivers/infiniband/core/ucma.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index 9520154..405d0ce 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -1584,8 +1584,11 @@ static ssize_t ucma_write(struct file *filp, const char __user *buf,
struct rdma_ucm_cmd_hdr hdr;
ssize_t ret;
- if (WARN_ON_ONCE(!ib_safe_file_access(filp)))
+ if (!ib_safe_file_access(filp)) {
+ printk_once("ucma_write: process %d (%s) tried to do something hinky\n",
+ task_tgid_vnr(current), current->comm);
return -EACCES;
+ }
if (len < sizeof(hdr))
return -EINVAL;
--
2.8.0.rc3.226.g39d4020
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v2] infiniband: remove WARN that is not kernel bug Dmitry Vyukov <dvyukov@google.com> - 2016-11-21 11:20 +0100
Re: [PATCH v2] infiniband: remove WARN that is not kernel bug Miroslav Benes <mbenes@suse.cz> - 2016-11-21 11:30 +0100
Re: [PATCH v2] infiniband: remove WARN that is not kernel bug Dmitry Vyukov <dvyukov@google.com> - 2016-11-21 11:40 +0100
Re: [PATCH v2] infiniband: remove WARN that is not kernel bug Dmitry Vyukov <dvyukov@google.com> - 2016-11-21 12:50 +0100
Re: [PATCH v2] infiniband: remove WARN that is not kernel bug Leon Romanovsky <leon@kernel.org> - 2016-11-21 13:20 +0100
Re: [PATCH v2] infiniband: remove WARN that is not kernel bug Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-21 18:00 +0100
Re: [PATCH v2] infiniband: remove WARN that is not kernel bug Leon Romanovsky <leon@kernel.org> - 2016-11-21 18:40 +0100
Re: [PATCH v2] infiniband: remove WARN that is not kernel bug Leon Romanovsky <leon@kernel.org> - 2016-11-21 12:50 +0100
csiph-web