Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target
Date	2016-11-21 10:00 +0100
Message-ID	<sFSCe-7mV-7@gated-at.bofh.it> (permalink)
References	<suFIm-4q7-27@gated-at.bofh.it> <suFS1-4IK-21@gated-at.bofh.it> <sEOKl-5WQ-5@gated-at.bofh.it> <sER5v-7vL-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

"Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> writes:
> On 2016/11/18 18:31, Michael Ellerman wrote:
>  >bamvor.zhangjian@huawei.com writes:
>  >> From: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
>  >> Currently, kselftest use TEST_PROGS, TEST_PROGS_EXTENDED, TEST_FILES to
>  >> indicate the default test program, extended test program and test files.
>  >> These lead to duplicated all and clean targets.
>  >>
>  >> In order to remove them, introduce TEST_GEN_PROGS,
>  >> TEST_GEN_PROGS_EXTENDED, TEST_GEN_FILES to indicate the compiled
>  >> objected.
>  >
>  >It's nice to be able to drop the clean rules, but renaming all those
>  >variables causes a lot of churn.
>  >
>  >I think it would be better if we add a new variable, maybe NO_CLEAN,
>  >which can be used to specify anything in TEST_PROGS/EXTENDED which
>  >should *not* be cleaned.
>  >
>  >And then the default clean rule will just do:
>  >
>  >clean:
>  >    $(RM) -fr $(filter-out $(NO_CLEAN),$(TEST_PROGS))

> Maybe I lost somewhere. I add these variable for all and
> clean target. They will be used to output the objects to OUTPUT
> directory.

No you're right, that won't work as I described it.

I reviewed this patch first and didn't look at how it was required for
patch 6 to work (and the change log doesn't mention that you need it for
patch 6 :)

> Could you please explain in details how should I do it for
> "all" target if I do not introduce TEST_GEN_PROGS,
> TEST_GEN_PROGS_EXTENDED and TEST_GEN_FILES?

I'll have to think about it a bit more.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target Michael Ellerman <mpe@ellerman.id.au> - 2016-11-18 11:40 +0100
  Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> - 2016-11-18 14:10 +0100
    Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target Michael Ellerman <mpe@ellerman.id.au> - 2016-11-21 10:00 +0100

csiph-web