Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1526375

Re: [PATCH] xen-scsifront: Add a missing call to kfree

Show all headers | View raw

On 19/11/16 19:22, Quentin Lambert wrote:
> Most error branches following the call to kmalloc contain
> a call to kfree. This patch add these calls where they are
> missing.
> 
> This issue was found with Hector.
> 
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>

Nice catch. I think this will need some more work, I'll do a
follow-on patch.

Reviewed-by: Juergen Gross <jgross@suse.com>

> 
> ---
>  drivers/scsi/xen-scsifront.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/scsi/xen-scsifront.c
> +++ b/drivers/scsi/xen-scsifront.c
> @@ -627,6 +627,7 @@ static int scsifront_action_handler(stru
>  
>  	if (scsifront_enter(info)) {
>  		spin_unlock_irq(host->host_lock);
> +		kfree(shadow);
>  		return FAILED;
>  	}
>  
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen-scsifront: Add a missing call to kfree Quentin Lambert <lambert.quentin@gmail.com> - 2016-11-19 19:30 +0100
  Re: [PATCH] xen-scsifront: Add a missing call to kfree Juergen Gross <jgross@suse.com> - 2016-11-21 07:10 +0100
    Re: [PATCH] xen-scsifront: Add a missing call to kfree "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-11-22 04:50 +0100
      Re: [PATCH] xen-scsifront: Add a missing call to kfree Juergen Gross <jgross@suse.com> - 2016-11-22 06:30 +0100
  Re: [PATCH] xen-scsifront: Add a missing call to kfree Juergen Gross <jgross@suse.com> - 2016-11-24 09:30 +0100

csiph-web