Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1526293

Re: [PATCH] x86/boot: Fail the boot if !M486 and CPUID is missing

Show all headers | View raw

On Sun, Nov 20, 2016 at 05:34:43PM -0200, Henrique de Moraes Holschuh wrote:
> On Sun, 20 Nov 2016, Borislav Petkov wrote:
> > We will have set (or not) the X86_FEATURE_CPUID bit at
> > early_identify_cpu() time. Looking at the code, we do call sync_core()
> > pretty early. :-\
> 
> Hmm, watch out for the early microcode update driver for Intel
> processors should something get changed in the implementation, or in the
> behavior of sync_core().

That's exactly what I had in mind when I wrote the above sentence...

> That driver absolutely needs to issue a cpuid (with EAX = 1) before each
> rdmsr(MSR_IA32_UCODE_REV).  And it uses sync_core() calls to do it.  A
> CR2 access just won't do in this extremely specific case.
> 
> This kind of pitfall is why I wanted to replace all use of sync_core()
> in arch/x86/kernel/cpu/microcode/intel.c with an explicit use of an
> inconditional cpuid(eax = 1)...
> 
> (note: this protocol to read MSR_IA32_UCODE_REV was made an
> architectural requirement a while ago -- it was once considered an
> erratum workaround.  It is documented in the "Intel 64 and IA‐32
> Architectures Software Developer's Manual", Volume 3A: System
> Programming Guide, Part 1, section 9.11).

Well, I'm looking at this:

"CPUID returns a value in a model specific register in addition to its
usual register return values. The semantics of CPUID cause it to deposit
an update ID value in the 64-bit model-specific register at address 08BH
(IA32_BIOS_SIGN_ID)."

And I think yes, we should do an explicit CPUID(1) regardless of
what happens to sync_core(). Feel free to send a patch against
tip:x86/microcode.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/boot: Fail the boot if !M486 and CPUID is missing Andy Lutomirski <luto@kernel.org> - 2016-11-20 00:40 +0100
  Re: [PATCH] x86/boot: Fail the boot if !M486 and CPUID is missing Borislav Petkov <bp@alien8.de> - 2016-11-20 12:20 +0100
    Re: [PATCH] x86/boot: Fail the boot if !M486 and CPUID is missing Andy Lutomirski <luto@amacapital.net> - 2016-11-20 17:30 +0100
      Re: [PATCH] x86/boot: Fail the boot if !M486 and CPUID is missing Borislav Petkov <bp@alien8.de> - 2016-11-20 18:40 +0100
        Re: [PATCH] x86/boot: Fail the boot if !M486 and CPUID is missing Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-11-20 20:40 +0100
          Re: [PATCH] x86/boot: Fail the boot if !M486 and CPUID is missing Borislav Petkov <bp@alien8.de> - 2016-11-20 21:50 +0100
  [tip:x86/urgent] x86/boot: Fail the boot if !M486 and CPUID is  missing tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2016-11-21 09:50 +0100

csiph-web