Re: [char-misc-next 4/4] mei: bus: enable non-blocking RX

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [char-misc-next 4/4] mei: bus: enable non-blocking RX
Date	2016-11-19 09:50 +0100
Message-ID	<sF9vs-2Ae-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <sEexc-7dl-35@gated-at.bofh.it> <sEymd-3v8-25@gated-at.bofh.it> <sEymd-3v8-27@gated-at.bofh.it> <sEymd-3v8-23@gated-at.bofh.it> <sEXaW-2W9-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 18, 2016 at 07:30:25PM +0000, Winkler, Tomas wrote:
> 
> > 
> > On Thu, Nov 17, 2016 at 04:22:24PM +0000, Winkler, Tomas wrote:
> > > > Just make a new function mei_cldev_recv_async() and then call a
> > > > local, static function, that does the work with the correct flag
> > > > set.  That way the developer always knows exactly what is going on.
> > >
> > > We can do a wrapper, but _async() is not proper here maybe
> > > _nonblock(),
> > 
> > Yes, I just guessed at the name :)
> 
> Understood, any how I believe that we should keep patch as is, there is no one
> API _nonblock() function in the whole kernel unlike _async(), 
> nonblock  is always passed in as a flag or Boolean. 

And I'll still argue that this is a horrible api and you can do better.
No need to duplicate the errors of our childhood :)

thanks,

greg k-h

Thread

[char-misc-next 4/4] mei: bus: enable non-blocking RX Tomas Winkler <tomas.winkler@intel.com> - 2016-11-16 21:00 +0100
  Re: [char-misc-next 4/4] mei: bus: enable non-blocking RX Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-17 18:10 +0100
    RE: [char-misc-next 4/4] mei: bus: enable non-blocking RX "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-11-18 20:40 +0100
      Re: [char-misc-next 4/4] mei: bus: enable non-blocking RX Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-19 09:50 +0100
        RE: [char-misc-next 4/4] mei: bus: enable non-blocking RX "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-11-19 11:50 +0100
  RE: [char-misc-next 4/4] mei: bus: enable non-blocking RX "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-11-17 18:40 +0100
  Re: [char-misc-next 4/4] mei: bus: enable non-blocking RX Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-17 19:10 +0100

csiph-web