[PATCH 2/3] pciehp: Fix led status when enabling already enabled slot.

From	Ashok Raj <ashok.raj@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/3] pciehp: Fix led status when enabling already enabled slot.
Date	2016-11-19 09:40 +0100
Message-ID	<sF9lL-2x2-7@gated-at.bofh.it> (permalink)
References	<sF9lL-2x2-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

If an error occurs enabling a slot on a hot plug event, the presence LED 
is disabled.

It is not an error, though, when the slot was already enabled. This
patch returns success if called to enable an already enabled slot. This
is in the same spirit of the special handling for EEXISTS when
pciehp_configure_device determines the slot devices already exist.

Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org

Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
---
 drivers/pci/hotplug/pciehp_ctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
index efe69e8..ec0b4c1 100644
--- a/drivers/pci/hotplug/pciehp_ctrl.c
+++ b/drivers/pci/hotplug/pciehp_ctrl.c
@@ -410,7 +410,7 @@ int pciehp_enable_slot(struct slot *p_slot)
 		if (getstatus) {
 			ctrl_info(ctrl, "Slot(%s): Already enabled\n",
 				  slot_name(p_slot));
-			return -EINVAL;
+			return 0;
 		}
 	}

-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Fix improper handling of pcie hotplug events. Ashok Raj <ashok.raj@intel.com> - 2016-11-19 09:40 +0100
  [PATCH 2/3] pciehp: Fix led status when enabling already enabled slot. Ashok Raj <ashok.raj@intel.com> - 2016-11-19 09:40 +0100

csiph-web