Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing
Date	2016-11-17 18:30 +0100
Message-ID	<sEyme-3v8-87@gated-at.bofh.it> (permalink)
References	<sEcvo-609-31@gated-at.bofh.it> <sEt3b-8sS-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 11/17/2016 06:28 AM, Olaf Hering wrote:
> On Wed, Nov 16, Boris Ostrovsky wrote:
>
>> Unfortunately I haven't been able to trigger NUMA balancing
>> so while I tested this in general I am not sure I actually
>> exercised the code path.
> Thanks for the patch!
>
> Would be nice to actually test the code path which caused the initial
> addition of VM_IO. I think I lack the hardware to excersise them.

To trip the original bug is even more difficult than to trigger NUMA
balancing. It was very sensitive to memory allocation.

>
>
> In my 4.4 based sources I get the following unresolved symbols. If that
> happens to work in mainline the failures should at least be considered
> during backporting of this proposed patch to the stable trees.
>
> ERROR: "__mpol_dup" [drivers/xen/xen-gntdev.ko] undefined!
> ERROR: "get_task_policy" [drivers/xen/xen-gntdev.ko] undefined!
>
> Appearently these symbols lack just an EXPORT_SYMBOL_GPL.


I just built 4.4.11 with this patch applied and haven't had any problems.

-boris

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-11-16 18:50 +0100
  Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to  avoid NUMA balancing Olaf Hering <olaf@aepfle.de> - 2016-11-17 12:30 +0100
    Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to  avoid NUMA balancing Olaf Hering <olaf@aepfle.de> - 2016-11-17 18:10 +0100
      Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to  avoid NUMA balancing Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-11-17 18:40 +0100
    Re: [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to  avoid NUMA balancing Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-11-17 18:30 +0100

csiph-web