Re: Boot failures in -next due to 'ARM: dts: imx: Remove skeleton.dtsi'

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: Boot failures in -next due to 'ARM: dts: imx: Remove skeleton.dtsi'
Date	2016-11-17 18:20 +0100
Message-ID	<sEymd-3v8-19@gated-at.bofh.it> (permalink)
References	(3 earlier) <sEgSm-rg-13@gated-at.bofh.it> <sEhbI-xX-3@gated-at.bofh.it> <sEsA9-838-3@gated-at.bofh.it> <sEymd-3v8-15@gated-at.bofh.it> <sEymd-3v8-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/17/2016 07:05 AM, Mark Rutland wrote:
> On Thu, Nov 17, 2016 at 06:44:55AM -0800, Guenter Roeck wrote:
>> On 11/17/2016 02:55 AM, Mark Rutland wrote:
>>> On Wed, Nov 16, 2016 at 02:40:24PM -0800, Guenter Roeck wrote:
>>>> On Wed, Nov 16, 2016 at 08:27:09PM -0200, Fabio Estevam wrote:
>>>>> Hi Guenter,
>>>>>
>>>>> On Wed, Nov 16, 2016 at 8:10 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>>>>>>
>>>>>> Anyway, I guess the problem is that the "official" dtb files no longer provide
>>>>>> the skeleton /chosen and /memory nodes (and maybe others), and qemu seems to
>>>>>> expect that they are provided. Is that correct ?
>>>>>
>>>>> imx6qdl-sabrelite.dtsi provides chosen and memory nodes.
>>>>
>>>> Yes, but not the 'device_type' property, which the kernel seems to expect.
>>>
>>> Memory nodes require this property per ePAPR and the devicetree.org
>>> spec, so the bug is that we didn't add those when removing the
>>> skeleton.dtsi include.
>>
>> The downside from qemu perspective is that the real hardware seems
>> to add the property unconditionally, or the boot failure would have
>> been seen there as well.
>>
>> I submitted https://patchwork.ozlabs.org/patch/695951/; we'll see how it goes.
>
> Sure, the firmare/bootlaoder you're using may add this automatically.
>
> My worry is that adding this to a generic file in QEMU only serves to
> mask this class of bug for other boards (i.e. they'll work fine in QEMU,
> but not on real HW using whatever bootlaoder happens ot be there).
>
Good point.

What would be the correct behavior for qemu ? Adding a chosen node if it does
not exist is one detail we already established. Also, I think a check if
/memory/device_type exists (and to bail out if it doesn't) would make sense.

What about the memory node ? Does it have to exist, or should it be added
(including the device_type property) if not ?

Thanks,
Guenter

Thread

Boot failures in -next due to 'ARM: dts: imx: Remove skeleton.dtsi' Guenter Roeck <linux@roeck-us.net> - 2016-11-16 18:50 +0100
  Re: Boot failures in -next due to 'ARM: dts: imx: Remove skeleton.dtsi' Fabio Estevam <festevam@gmail.com> - 2016-11-16 19:50 +0100
  Re: Boot failures in -next due to 'ARM: dts: imx: Remove  skeleton.dtsi' Mark Rutland <mark.rutland@arm.com> - 2016-11-16 19:50 +0100
    Re: Boot failures in -next due to 'ARM: dts: imx: Remove  skeleton.dtsi' Guenter Roeck <linux@roeck-us.net> - 2016-11-16 23:20 +0100
      Re: Boot failures in -next due to 'ARM: dts: imx: Remove skeleton.dtsi' Fabio Estevam <festevam@gmail.com> - 2016-11-16 23:30 +0100
        Re: Boot failures in -next due to 'ARM: dts: imx: Remove  skeleton.dtsi' Guenter Roeck <linux@roeck-us.net> - 2016-11-16 23:50 +0100
          Re: Boot failures in -next due to 'ARM: dts: imx: Remove skeleton.dtsi' Fabio Estevam <festevam@gmail.com> - 2016-11-17 00:00 +0100
          Re: Boot failures in -next due to 'ARM: dts: imx: Remove  skeleton.dtsi' Mark Rutland <mark.rutland@arm.com> - 2016-11-17 12:00 +0100
            Re: Boot failures in -next due to 'ARM: dts: imx: Remove  skeleton.dtsi' Mark Rutland <mark.rutland@arm.com> - 2016-11-17 18:10 +0100
              Re: Boot failures in -next due to 'ARM: dts: imx: Remove  skeleton.dtsi' Guenter Roeck <linux@roeck-us.net> - 2016-11-17 18:30 +0100
            Re: Boot failures in -next due to 'ARM: dts: imx: Remove  skeleton.dtsi' Guenter Roeck <linux@roeck-us.net> - 2016-11-17 18:20 +0100
            Re: Boot failures in -next due to 'ARM: dts: imx: Remove  skeleton.dtsi' Mark Rutland <mark.rutland@arm.com> - 2016-11-17 18:40 +0100
            Re: Boot failures in -next due to 'ARM: dts: imx: Remove  skeleton.dtsi' Guenter Roeck <linux@roeck-us.net> - 2016-11-17 19:10 +0100

csiph-web