Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1524466

Re: [RFC PATCH] of: base: add support to get machine model name

From Sudeep Holla <sudeep.holla@arm.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH] of: base: add support to get machine model name
Date 2016-11-17 15:40 +0100
Message-ID <sEw15-1T0-85@gated-at.bofh.it> (permalink)
References <sEtwd-b3-11@gated-at.bofh.it> <sEvRn-1Pv-3@gated-at.bofh.it> <sEvRn-1Pv-5@gated-at.bofh.it> <sEvRn-1Pv-1@gated-at.bofh.it>
Organization ARM

Show all headers | View raw



On 17/11/16 14:13, Arnd Bergmann wrote:
> On Thursday, November 17, 2016 2:08:30 PM CET Sudeep Holla wrote:
>> On 17/11/16 13:50, Arnd Bergmann wrote:
>>> On Thursday, November 17, 2016 11:50:50 AM CET Sudeep Holla wrote:
>>>> Currently platforms/drivers needing to get the machine model name are
>>>> replicating the same snippet of code. In some case, the OF reference
>>>> counting is either missing or incorrect.
>>>>
>>>> This patch adds support to read the machine model name either using
>>>> the "model" or the "compatible" property in the device tree root node.
>>>>
>>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>>>
>>> I like the idea. One small comment:
>>>
>>
>> Thanks. I prefer it as single patch but it can't be applied to any tree.
>> Any suggestions on handling this patch to fix the warning in -next ?
>>
> The patch that causes the warning is currently in the mmc tree, and I
> don't think it would be good to have your entire patch in there too.
>
> It's probably best to just fix the warning there now by adding another
> open-coded copy of that function, and then apply your patch on top
> for v4.11.

Sure, that's much simpler to deal with for now.

-- 
Regards,
Sudeep

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH] of: base: add support to get machine model name Sudeep Holla <sudeep.holla@arm.com> - 2016-11-17 13:00 +0100
  Re: [RFC PATCH] of: base: add support to get machine model name Arnd Bergmann <arnd@arndb.de> - 2016-11-17 15:30 +0100
    Re: [RFC PATCH] of: base: add support to get machine model name Sudeep Holla <sudeep.holla@arm.com> - 2016-11-17 15:40 +0100
  Re: [RFC PATCH] of: base: add support to get machine model name Sudeep Holla <sudeep.holla@arm.com> - 2016-11-17 15:30 +0100
  Re: [RFC PATCH] of: base: add support to get machine model name Arnd Bergmann <arnd@arndb.de> - 2016-11-17 19:30 +0100

csiph-web