Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1524423

Re: [PATCH 4.8 78/92] batman-adv: fix splat on disabling an interface

Show all headers | View raw

On Thu, Nov 17, 2016 at 11:51:24AM +0100, Sven Eckelmann wrote:
> On Donnerstag, 17. November 2016 11:32:51 CET Greg Kroah-Hartman wrote:
> > 4.8-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Linus Lüssing <linus.luessing@c0d3.blue>
> > 
> > commit 9799c50372b23ed774791bdb87d700f1286ee8a9 upstream.
> > 
> > As long as there is still a reference for a hard interface held, there might
> > still be a forwarding packet relying on its attributes.
> > 
> > Therefore avoid setting hard_iface->soft_iface to NULL when disabling a hard
> > interface.
> > 
> > This fixes the following, potential splat:
> > 
> [...]
> 
> Thanks for your backporting efforts. There is already a revert for this patch
> queued up in batadv/net [1] (targets net.git). So maybe you want to drop this
> patch from your stable queue.
> 
> We also got test results from Linus which showed that this problem didn't
> happen anymore with recent kernel versions (without his patch). These results
> made him also Ack the revert.
> 
> Sorry about this confusing situation.

Not a problem, I've dropped this one from the patch queue now, thanks
for letting me know.

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4.8 78/92] batman-adv: fix splat on disabling an interface Sven Eckelmann <sven@narfation.org> - 2016-11-17 12:00 +0100
  Re: [PATCH 4.8 78/92] batman-adv: fix splat on disabling an interface Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-17 13:10 +0100

csiph-web