Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1524227
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] thunderbolt: fix compile-test dependencies |
| Date | 2016-11-17 11:10 +0100 |
| Message-ID | <sErNM-7If-39@gated-at.bofh.it> (permalink) |
| References | <sDOjo-6QT-27@gated-at.bofh.it> <sDOMp-7jG-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tuesday, November 15, 2016 5:21:34 PM CET Lukas Wunner wrote: > On Tue, Nov 15, 2016 at 04:58:53PM +0100, Arnd Bergmann wrote: > > diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig > > index 0056df7f3c09..4e7d92193b65 100644 > > --- a/drivers/thunderbolt/Kconfig > > +++ b/drivers/thunderbolt/Kconfig > > @@ -1,7 +1,8 @@ > > menuconfig THUNDERBOLT > > tristate "Thunderbolt support for Apple devices" > > + depends on (EFI_STUB && X86) || COMPILE_TEST > > This addition isn't correct, the thunderbolt driver works without > the EFI stub, it just falls back to a hardcoded Device ROM. Ok, makes sense. I also needed this one though: diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig index bb0318ceaf93..de5d27ec67d6 100644 --- a/drivers/thunderbolt/Kconfig +++ b/drivers/thunderbolt/Kconfig @@ -1,7 +1,7 @@ menuconfig THUNDERBOLT tristate "Thunderbolt support for Apple devices" depends on PCI - select APPLE_PROPERTIES if EFI_STUB + select APPLE_PROPERTIES if EFI_STUB && X86 select CRC32 help Cactus Ridge Thunderbolt Controller driver Without that change, building on ARM with EFI_STUB enabled still gives me a build failure. Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] thunderbolt: fix compile-test dependencies Arnd Bergmann <arnd@arndb.de> - 2016-11-15 17:00 +0100
Re: [PATCH] thunderbolt: fix compile-test dependencies Lukas Wunner <lukas@wunner.de> - 2016-11-15 17:30 +0100
Re: [PATCH] thunderbolt: fix compile-test dependencies Arnd Bergmann <arnd@arndb.de> - 2016-11-17 11:10 +0100
Re: [PATCH] thunderbolt: fix compile-test dependencies Lukas Wunner <lukas@wunner.de> - 2016-11-17 15:40 +0100
Re: [PATCH] thunderbolt: fix compile-test dependencies Lukas Wunner <lukas@wunner.de> - 2016-11-17 18:40 +0100
Re: [PATCH] thunderbolt: fix compile-test dependencies Arnd Bergmann <arnd@arndb.de> - 2016-11-17 18:10 +0100
Re: [PATCH] thunderbolt: fix compile-test dependencies Arnd Bergmann <arnd@arndb.de> - 2016-11-17 18:20 +0100
Re: [PATCH] thunderbolt: fix compile-test dependencies Lukas Wunner <lukas@wunner.de> - 2016-11-17 18:40 +0100
csiph-web