Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1524082
| From | "pankaj.dubey" <pankaj.dubey@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 12/16] ARM: imx: use generic API for enabling SCU |
| Date | 2016-11-17 05:30 +0100 |
| Message-ID | <sEmuJ-49B-9@gated-at.bofh.it> (permalink) |
| References | <sDhx7-26l-15@gated-at.bofh.it> <sDhGN-2pH-9@gated-at.bofh.it> <sEmuJ-49B-11@gated-at.bofh.it> <sDqqJ-892-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Shawn, On Monday 14 November 2016 07:56 PM, Shawn Guo wrote: > On Mon, Nov 14, 2016 at 10:32:07AM +0530, Pankaj Dubey wrote: >> Now as we have of_scu_enable which takes care of mapping >> scu base from DT, lets use it. >> >> At the same time this patch cleans up mach-imx platform files by >> removing static mapping of SCU and dropping imx_scu_map_io function. > > I remember that the static mapping of SCU is necessary because SCU is > being accessed at very early boot stage where dynamic mapping hasn't > been set up. > >> CC: Shawn Guo <shawnguo@kernel.org> >> CC: Sascha Hauer <kernel@pengutronix.de> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >> --- >> arch/arm/mach-imx/common.h | 5 ----- >> arch/arm/mach-imx/mach-imx6q.c | 8 +------- >> arch/arm/mach-imx/platsmp.c | 32 +++++--------------------------- >> arch/arm/mach-imx/pm-imx6.c | 3 ++- >> 4 files changed, 8 insertions(+), 40 deletions(-) > > I tested it and saw that the booting of imx6q is broken like below. Thanks for testing and letting me know about this. Currently only two platforms (IMX and ZYNQ) are using SCU address at very early stage of boot, for configuring possible cpus via set_cpu_possible().. rest platforms are either using DT method or they handle this in smp_prepare_cpus. Since I am not sure if all boards based on IMX has been moved to DT based boot, if it has moved to completely DT based then we do not need this set_cpu_possible in smp_init_cpus, it will be taken care via "arm_dt_init_cpu_maps" and this will avoid need of early mapping of SCU base as well. If not then, currently I can't see any other way to handle this and in that case I will drop-out IMX platform's patch of using generic SCU APIs in v2 version of series. Thanks, Pankaj Dubey
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/16] Provide support of generic function for SCU enable Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:00 +0100
[PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:00 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Jisheng Zhang <jszhang@marvell.com> - 2016-11-14 07:20 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Jisheng Zhang <jszhang@marvell.com> - 2016-11-14 08:10 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU "pankaj.dubey" <pankaj.dubey@samsung.com> - 2016-11-14 10:00 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Jisheng Zhang <jszhang@marvell.com> - 2016-11-14 10:00 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU "pankaj.dubey" <pankaj.dubey@samsung.com> - 2016-11-14 09:40 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Arnd Bergmann <arnd@arndb.de> - 2016-11-14 13:10 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-14 15:00 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Arnd Bergmann <arnd@arndb.de> - 2016-11-14 15:40 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-14 16:00 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU "pankaj.dubey" <pankaj.dubey@samsung.com> - 2016-11-17 05:30 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Arnd Bergmann <arnd@arndb.de> - 2016-11-17 18:10 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU "pankaj.dubey" <pankaj.dubey@samsung.com> - 2016-11-18 04:30 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Arnd Bergmann <arnd@arndb.de> - 2016-11-18 13:20 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-18 13:50 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Arnd Bergmann <arnd@arndb.de> - 2016-11-18 14:40 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-14 14:50 +0100
Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU "pankaj.dubey" <pankaj.dubey@samsung.com> - 2016-11-17 03:20 +0100
[PATCH 09/16] ARM: BCM: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
Re: [PATCH 09/16] ARM: BCM: use generic API for enabling SCU Florian Fainelli <f.fainelli@gmail.com> - 2016-11-14 07:20 +0100
[PATCH 06/16] ARM: STi: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
[PATCH 15/16] ARM: mvebu: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
[PATCH 12/16] ARM: imx: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
Re: [PATCH 12/16] ARM: imx: use generic API for enabling SCU Shawn Guo <shawnguo@kernel.org> - 2016-11-14 15:30 +0100
Re: [PATCH 12/16] ARM: imx: use generic API for enabling SCU "pankaj.dubey" <pankaj.dubey@samsung.com> - 2016-11-17 05:30 +0100
[PATCH 13/16] ARM: zynq: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
[PATCH 08/16] ARM: vexpress: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
Re: [PATCH 08/16] ARM: vexpress: use generic API for enabling SCU Sudeep Holla <sudeep.holla@arm.com> - 2016-11-16 15:40 +0100
Re: [PATCH 08/16] ARM: vexpress: use generic API for enabling SCU "pankaj.dubey" <pankaj.dubey@samsung.com> - 2016-11-17 03:20 +0100
[PATCH 05/16] ARM: socfpga: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
[PATCH 03/16] ARM: berlin: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
Re: [PATCH 03/16] ARM: berlin: use generic API for enabling SCU Jisheng Zhang <jszhang@marvell.com> - 2016-11-14 10:00 +0100
Re: [PATCH 03/16] ARM: berlin: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 17:30 +0100
[PATCH 10/16] ARM: tegra: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
[PATCH 16/16] ARM: zx: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
[PATCH 11/16] ARM: rockchip: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
[PATCH 14/16] ARM: hisi: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
[PATCH 07/16] ARM: ux500: use generic API for enabling SCU Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-11-14 06:10 +0100
csiph-web