Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1524078

Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf

Show all headers | View raw

On 16 November 2016 at 19:39, Wangnan (F) <wangnan0@huawei.com> wrote:
>
>
> On 2016/11/17 10:46, Joe Stringer wrote:
>>
>> On 16 November 2016 at 18:10, Wangnan (F) <wangnan0@huawei.com> wrote:
>>>
>>> I'm also working on improving bpf.c. Please have a look at:
>>>
>>> https://lkml.org/lkml/2016/11/14/1078
>>>
>>> Since bpf.c is simple, I think we can add more functions and fixes
>>> gradually, instead of a full copy.
>>>
>>> See my inline comment below.
>>
>> Ah, I missed this, my apologies. It looks like it will provide much of
>> what I need, I can reassess this patch with your series in mind.
>>
>> One comment though for your patch (I don't have the original thread to
>> respond to unfortunately): The map_pin and map_get functions in your
>> patch series can be used to pin progs too, so maybe there is a better
>> name? You'll see that this patch uses bpf_obj_{pin,get}() - although I
>> wouldn't want those to be confused with the libbpf.c objects so maybe
>> there's a clearer name that could be used.
>>
>> I also have some patches to rework the samples/bpf/* code to use
>> libbpf instead of the sample code that is there, is it worth me
>> submitting that? It will need to wait for your patch to go in, plus a
>> merge with davem's tree.
>>
> I'm happy to see you are trying to replace samples/bpf 's own
> libbpf with tools/lib/bpf. I think you can submit your work
> on libbpf and patches on samples together if they are ready.
> Arnaldo can pick up patches good for him, and you can improve
> other patches based on his newest branch.

I'll look into it.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 perf/core 0/2] libbpf: Synchronize implementations Joe Stringer <joe@ovn.org> - 2016-11-16 18:50 +0100
  [PATCHv2 perf/core 1/2] tools lib bpf: Sync {tools,}/include/uapi/linux/bpf.h Joe Stringer <joe@ovn.org> - 2016-11-16 18:50 +0100
    Re: [PATCHv2 perf/core 1/2] tools lib bpf: Sync  {tools,}/include/uapi/linux/bpf.h "Wangnan (F)" <wangnan0@huawei.com> - 2016-11-17 02:30 +0100
  [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf Joe Stringer <joe@ovn.org> - 2016-11-16 18:50 +0100
    Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with  samples/bpf/libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2016-11-17 03:20 +0100
      Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf Joe Stringer <joe@ovn.org> - 2016-11-17 03:50 +0100
        Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with  samples/bpf/libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2016-11-17 04:30 +0100
          Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf Joe Stringer <joe@ovn.org> - 2016-11-17 04:50 +0100
        Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with  samples/bpf/libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2016-11-17 04:50 +0100
          Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf Joe Stringer <joe@ovn.org> - 2016-11-17 05:00 +0100

csiph-web