[PATCH] mtd: maps: add missing iounmap() in error path

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Luis Henriques <henrix@camandro.org>
Newsgroups	linux.kernel
Subject	[PATCH] mtd: maps: add missing iounmap() in error path
Date	Thu, 17 Nov 2016 00:00:02 +0100
Message-ID	<sEhlo-Bi-23@gated-at.bofh.it> (permalink)
X-Original-To	David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, Marek Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, Cyrille Pitchen <cyrille.pitchen@atmel.com>
X-Blackcat-Spam-Score	-28
X-Mythic-Debug	Threshold = On =
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Luis Henriques <henrix@camandro.org>
X-Original-Date	Wed, 16 Nov 2016 22:50:16 +0000
X-Original-Message-ID	<20161116225016.29958-1-henrix@camandro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1523956

Show key headers only | View raw

This patch was triggered by the following Coccinelle error:

./drivers/mtd/maps/sc520cdp.c:246:3-9: \
	ERROR: missing iounmap; ioremap on line 242 \
	and execution via conditional on line 244

Signed-off-by: Luis Henriques <henrix@camandro.org>
---
 drivers/mtd/maps/sc520cdp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/maps/sc520cdp.c b/drivers/mtd/maps/sc520cdp.c
index 093edd51bdc7..7a27ed345d0d 100644
--- a/drivers/mtd/maps/sc520cdp.c
+++ b/drivers/mtd/maps/sc520cdp.c
@@ -243,6 +243,10 @@ static int __init init_sc520cdp(void)
 
 		if (!sc520cdp_map[i].virt) {
 			printk("Failed to ioremap_nocache\n");
+			if (i) {
+				while (--i)
+					iounmap(sc520cdp_map[i].virt);
+			}
 			return -EIO;
 		}

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: maps: add missing iounmap() in error path Luis Henriques <henrix@camandro.org> - 2016-11-17 00:00 +0100
  Re: [PATCH] mtd: maps: add missing iounmap() in error path Marek Vasut <marek.vasut@gmail.com> - 2016-11-20 23:10 +0100
  Re: [PATCH] mtd: maps: add missing iounmap() in error path Brian Norris <computersforpeace@gmail.com> - 2016-11-22 20:30 +0100
    Re: [PATCH] mtd: maps: add missing iounmap() in error path Luis Henriques <henrix@camandro.org> - 2016-11-23 17:30 +0100
    [PATCH v2] mtd: maps: add missing iounmap() in error path Luis Henriques <henrix@camandro.org> - 2016-11-24 00:50 +0100

csiph-web