Re: [PATCH] mtd: nand: nandsim: fix error check

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: nand: nandsim: fix error check
Date	2016-11-16 22:00 +0100
Message-ID	<sEftg-7M4-35@gated-at.bofh.it> (permalink)
References	<sDVbb-2Za-7@gated-at.bofh.it> <sDVEd-38z-3@gated-at.bofh.it> <sE3ip-8p6-9@gated-at.bofh.it> <sEbJ0-5pV-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 16 November 2016 04:56 PM, Marek Vasut wrote:
> On 11/16/2016 08:52 AM, Sudip Mukherjee wrote:
>> On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote:
>>> On 11/16/2016 12:09 AM, Sudip Mukherjee wrote:
>>>> debugfs_create_dir() and debugfs_create_file() returns NULL on error or
>>>> a pointer on success. They do not return the error value with ERR_PTR.
>>>> So we should not check the return with IS_ERR_OR_NULL, instead we
>>>> should just check for NULL.
>>>>
>>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>>>> ---
>>>>    drivers/mtd/nand/nandsim.c | 9 +++------
>>>>    1 file changed, 3 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
>>>> index c76287a..9b0d79a 100644
>>>> --- a/drivers/mtd/nand/nandsim.c
>>>> +++ b/drivers/mtd/nand/nandsim.c
>>>> @@ -525,15 +525,13 @@ static int nandsim_debugfs_create(struct
>>>> nandsim *dev)
>>>>    {
>>>>        struct nandsim_debug_info *dbg = &dev->dbg;
>>>>        struct dentry *dent;
>>>> -    int err;
>>>> +    int err = -ENODEV;
>>>
>>> Why don't you just nuke the err altogether and just return -ENODEV ?
>>
>> That was the first version which i made and discarded before sending. I
>> will go and find it now.
>
> Why did you discard it ?
>

That is actually a stupid reason. I was confused with the print 
statement which uses err.

NS_ERR("cannot create \"nandsim\" debugfs directory, err %d\n",
			err);


Regards
Sudip

Thread

[PATCH] mtd: nand: nandsim: fix error check Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-11-16 00:20 +0100
  Re: [PATCH] mtd: nand: nandsim: fix error check Marek Vasut <marek.vasut@gmail.com> - 2016-11-16 00:50 +0100
    Re: [PATCH] mtd: nand: nandsim: fix error check Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-11-16 09:00 +0100
      Re: [PATCH] mtd: nand: nandsim: fix error check Marek Vasut <marek.vasut@gmail.com> - 2016-11-16 18:00 +0100
        Re: [PATCH] mtd: nand: nandsim: fix error check Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-11-16 22:00 +0100
          Re: [PATCH] mtd: nand: nandsim: fix error check Marek Vasut <marek.vasut@gmail.com> - 2016-11-17 15:40 +0100
            Re: [PATCH] mtd: nand: nandsim: fix error check Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-11-17 18:30 +0100

csiph-web