Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1523786

Re: [PATCH] pinctrl: sunxi: fix theoretical uninitialized variable access

Show all headers | View raw

On Wed, Nov 16, 2016 at 3:18 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> gcc warns about a  way that it could use an uninitialized variable:
>
> drivers/pinctrl/sunxi/pinctrl-sunxi.c: In function 'sunxi_pinctrl_init':
> drivers/pinctrl/sunxi/pinctrl-sunxi.c:1191:8: error: 'best_div' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This cannot really happen except if 'freq' is UINT_MAX and 'clock' is
> zero, and both of these are forbidden. To shut up the warning anyway,
> this changes the logic to initialize the return code to the first
> divider value before looking at the others.
>
> Fixes: 7c926492d38a ("pinctrl: sunxi: Add support for interrupt debouncing")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: sunxi: fix theoretical uninitialized variable access Arnd Bergmann <arnd@arndb.de> - 2016-11-16 15:30 +0100
  Re: [PATCH] pinctrl: sunxi: fix theoretical uninitialized variable access Linus Walleij <linus.walleij@linaro.org> - 2016-11-16 21:00 +0100
  Re: [PATCH] pinctrl: sunxi: fix theoretical uninitialized variable  access Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-16 21:40 +0100
    Re: [PATCH] pinctrl: sunxi: fix theoretical uninitialized variable access Linus Walleij <linus.walleij@linaro.org> - 2016-11-17 10:10 +0100
      Re: [PATCH] pinctrl: sunxi: fix theoretical uninitialized variable access Arnd Bergmann <arnd@arndb.de> - 2016-11-17 10:30 +0100
      Re: [PATCH] pinctrl: sunxi: fix theoretical uninitialized variable  access Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-17 10:30 +0100

csiph-web