Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1523767

[PATCH 2/3] net: stmmac: replace hardcoded function name by __func__

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Corentin Labbe <clabbe.montjoie@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/3] net: stmmac: replace hardcoded function name by __func__
Date Wed, 16 Nov 2016 20:20:01 +0100
Message-ID <sEdUt-70N-23@gated-at.bofh.it> (permalink)
References <sEdUt-70N-5@gated-at.bofh.it>
X-Original-To peppe.cavallaro@st.com, alexandre.torgue@st.com
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SmPji1bBN2ydcqH+fekH24pHr9awKWCt0xW6MLATliE=; b=vwZs9cft5VcydGRQLHdTnqrQm/W9LP8KE4dEZF864ZB+rmelsd6eTfZsKDs8OqypKv GsMuxO/uAZeONuC0a9X0wlEtUZlhtcXd1SuxSKyqPDygvMJw4VpXjvKOhE+z/lV/n/wZ oYgSq9UvzP4pmrjO7lFtoXF8MY8cnrwiYwEzt5j9tHorlqjpVQrxAm5vlPrzXCeQvhyL Y+pEDDrt058PgwQVPF0r+SoKcxL8KtCrLxWK53uAU+Ps6vaOeREWXMZgPGZFf2lIwzB/ Xm4ztn+4ctM6Lf4vaAML7miRO7wObNrDHlJ253zbBe60m7//vwRfmig/pjL5fdNmBNZ8 buVw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SmPji1bBN2ydcqH+fekH24pHr9awKWCt0xW6MLATliE=; b=YPt+GdSstF3a/70B68ujLTnexBryes7ZM5A7kQYNx57HMkiGQepBEs+coHTgLYFFN1 gMT0Okcpm6NmpUyxtMN/+8FNujltpk/pZL+AcrVEdfHknpBi5embR76qja+iusBQYnXT E9wg3q3pJEd4vaT9wIvsKZT/AxNVeh31/dUd+oPsQBXeMYj8B6PQ6h6I8vak4XkMKVHe gpSo24CfwIMJxaRATTvBMz9/5gqpSUIkA0PF+JCSBtayoNpThm1EHj3bEdjOUAnjAwbz o94P3NLmkMDb7yFuID+5UywMVm/8vSVIYIM6ucyQ7y9BLer7KLBq3+9F1hyODY9htSsv qn5w==
X-Gm-Message-State ABUngvcM9kfr/a0V4tXOteVvYcCPt0L0Zdp0+DNGVSc/xr3ggBcP/IeCQ7RmTOO+AQlKfw==
X-Received by 10.28.152.79 with SMTP id a76mr12144593wme.47.1479323572007; Wed, 16 Nov 2016 11:12:52 -0800 (PST)
X-Mailer git-send-email 2.7.3
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 37
Organization linux.* mail to news gateway
X-Original-Cc netdev@vger.kernel.org, linux-kernel@vger.kernel.org, LABBE Corentin <clabbe.montjoie@gmail.com>
X-Original-Date Wed, 16 Nov 2016 20:09:40 +0100
X-Original-Message-ID <1479323381-26639-2-git-send-email-clabbe.montjoie@gmail.com>
X-Original-References <1479323381-26639-1-git-send-email-clabbe.montjoie@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1523767

Show key headers only | View raw


From: LABBE Corentin <clabbe.montjoie@gmail.com>

Some printing have the function name hardcoded.
It is better to use __func__ instead.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 791daf4..d160bdb 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -849,7 +849,7 @@ static int stmmac_init_phy(struct net_device *dev)
 
 		snprintf(phy_id_fmt, MII_BUS_ID_SIZE + 3, PHY_ID_FMT, bus_id,
 			 priv->plat->phy_addr);
-		netdev_dbg(priv->dev, "stmmac_init_phy: trying to attach to %s\n",
+		netdev_dbg(priv->dev, "%s: trying to attach to %s\n", __func__,
 			   phy_id_fmt);
 
 		phydev = phy_connect(dev, phy_id_fmt, &stmmac_adjust_link,
@@ -890,9 +890,8 @@ static int stmmac_init_phy(struct net_device *dev)
 	if (phydev->is_pseudo_fixed_link)
 		phydev->irq = PHY_POLL;
 
-	netdev_dbg(priv->dev,
-		   "stmmac_init_phy: attached to PHY (UID 0x%x) Link = %d\n",
-		   phydev->phy_id, phydev->link);
+	netdev_dbg(priv->dev, "%s: attached to PHY (UID 0x%x) Link = %d\n",
+		   __func__, phydev->phy_id, phydev->link);
 
 	return 0;
 }
-- 
2.7.3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] net: stmmac: replace all pr_xxx by their netdev_xxx counterpart Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-11-16 20:20 +0100
  [PATCH 3/3] net: stmmac: replace if (netif_msg_type) by their netif_xxx counterpart Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-11-16 20:20 +0100
    Re: [PATCH 3/3] net: stmmac: replace if (netif_msg_type) by their  netif_xxx counterpart David Miller <davem@davemloft.net> - 2016-11-17 19:40 +0100
  [PATCH 2/3] net: stmmac: replace hardcoded function name by __func__ Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-11-16 20:20 +0100
    Re: [PATCH 2/3] net: stmmac: replace hardcoded function name by  __func__ David Miller <davem@davemloft.net> - 2016-11-17 19:40 +0100
  Re: [PATCH 1/3] net: stmmac: replace all pr_xxx by their netdev_xxx  counterpart Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2016-11-17 18:50 +0100
  Re: [PATCH 1/3] net: stmmac: replace all pr_xxx by their  netdev_xxx counterpart David Miller <davem@davemloft.net> - 2016-11-17 19:40 +0100

csiph-web