Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1525715

Re: [PATCH] phy: rockchip-inno-usb2: add extcon dependency

Show all headers | View raw

On Fri, Nov 18, 2016 at 8:36 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> If extcon is a loadable module and rockchip-inno-usb2 is built-in,
> we get a link failure:
>
> drivers/phy/phy-rockchip-inno-usb2.o: In function `rockchip_usb2phy_probe':
> phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x1ec): undefined reference to `extcon_get_edev_by_phandle'
> phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x25c): undefined reference to `devm_extcon_dev_allocate'
> phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x2a8): undefined reference to `devm_extcon_dev_register'
> phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0xa28): undefined reference to `extcon_register_notifier'
>
> Adding a hard dependency avoids the problem. Alternatively we could
> use "depends on EXTCON || !EXTCON" to allow building with extcon
> disabled completely, but the other PHY drivers with extcon support
> also just have a dependency, so this is more consistent.
>
> Fixes: 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looking into the source, extcon support is now mandatory for this
driver, so adding the dependency makes sense.

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
>  drivers/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 53cab9f3323b..b135ff1ab12d 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -366,6 +366,7 @@ config PHY_ROCKCHIP_INNO_USB2
>         depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
>         depends on COMMON_CLK
>         depends on USB_SUPPORT
> +       depends on EXTCON
>         select GENERIC_PHY
>         select USB_COMMON
>         help
> --
> 2.9.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] phy: rockchip-inno-usb2: add extcon dependency Arnd Bergmann <arnd@arndb.de> - 2016-11-18 17:40 +0100
  Re: [PATCH] phy: rockchip-inno-usb2: add extcon dependency Guenter Roeck <groeck@google.com> - 2016-11-18 22:30 +0100

csiph-web