Re: [PATCH 2/2] sunbmac: Fix compiler warning

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] sunbmac: Fix compiler warning
Date	2016-11-18 20:40 +0100
Message-ID	<sEXaW-2W9-31@gated-at.bofh.it> (permalink)
References	<stnaN-c4-3@gated-at.bofh.it> <stnaN-c4-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Tushar Dave <tushar.n.dave@oracle.com>
Date: Mon, 17 Oct 2016 13:57:00 -0700

> sunbmac uses '__u32' for dma handle while invoking kernel DMA APIs,
> instead of using dma_addr_t. This hasn't caused any 'incompatible
> pointer type' warning on SPARC because until now dma_addr_t is of
> type u32. However, recent changes in SPARC ATU (iommu) enables 64bit
> DMA and therefore dma_addr_t becomes of type u64. This makes
> 'incompatible pointer type' warnings inevitable.
> 
> e.g.
> drivers/net/ethernet/sun/sunbmac.c: In function ‘bigmac_ether_init’:
> drivers/net/ethernet/sun/sunbmac.c:1166: warning: passing argument 3 of ‘dma_alloc_coherent’ from incompatible pointer type
> ./include/linux/dma-mapping.h:445: note: expected ‘dma_addr_t *’ but argument is of type ‘__u32 *’
> 
> This patch resolves above compiler warning.
> 
> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
> Reviewed-by: chris hyser <chris.hyser@oracle.com>

Applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] sunbmac: Fix compiler warning David Miller <davem@davemloft.net> - 2016-11-18 20:40 +0100

csiph-web