Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1525678

Re: [PATCH 2/3] [media] v4l: rcar_fdp1: add FCP dependency

Show all headers | View raw

On Friday, November 18, 2016 6:08:01 PM CET Geert Uytterhoeven wrote:
> > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> > index 3c5a0b6b23a9..cd0cab6e0e31 100644
> > --- a/drivers/media/platform/Kconfig
> > +++ b/drivers/media/platform/Kconfig
> > @@ -311,6 +311,7 @@ config VIDEO_RENESAS_FDP1
> >         tristate "Renesas Fine Display Processor"
> >         depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA
> >         depends on ARCH_SHMOBILE || COMPILE_TEST
> > +       depends on (!ARCH_RENESAS && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> 
> Which tree and config is this? I don't have fdp1_pm_runtime_resume in my
> renesas-drivers tree.
> 
> Why are the dummies for !CONFIG_VIDEO_RENESAS_FCP in include/media/rcar-fcp.h
> not working?

Oops, I forgot to write a proper changelog.

Commit 4710b752e029 ("[media] v4l: Add Renesas R-Car FDP1 Driver") in the
v4l-dvb tree adds CONFIG_VIDEO_RENESAS_FDP1.

It calls into the FCP driver, but when there is no dependency, FCP might
be a module while FDP1 is built-in.

We have the same logic in VIDEO_RENESAS_VSP1, which also depends on
FCP not being a module when it is built-in itself.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] [media] v4l: rcar_fdp1: add FCP dependency Arnd Bergmann <arnd@arndb.de> - 2016-11-18 17:20 +0100
  Re: [PATCH 2/3] [media] v4l: rcar_fdp1: add FCP dependency Geert Uytterhoeven <geert@linux-m68k.org> - 2016-11-18 18:10 +0100
    Re: [PATCH 2/3] [media] v4l: rcar_fdp1: add FCP dependency Arnd Bergmann <arnd@arndb.de> - 2016-11-18 20:40 +0100

csiph-web