Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1525674
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic |
| Date | 2016-11-18 20:30 +0100 |
| Message-ID | <sEX1f-2SU-3@gated-at.bofh.it> (permalink) |
| References | <sEymf-3v8-101@gated-at.bofh.it> <sEW5b-2jW-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 18/11/2016 19:20, David Hildenbrand wrote: > Am 17.11.2016 um 15:55 schrieb Paolo Bonzini: >> kvm_arch_set_irq is unused since commit b97e6de9c96. Merge >> its functionality with kvm_arch_set_irq_inatomic. >> >> Reported-by: Jiang Biao <jiang.biao2@zte.com.cn> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> >> --- > > As you said, it is unused. Therefore the functionality is superfluous. > Why merge it? Because we can handle Hyper-V synthetic interrupts atomically, and that was the intended usage of kvm_arch_set_irq's code (see commit c9a5eccac1ab, "kvm/eventfd: add arch-specific set_irq", 2015-10-16). What happened was that the API changed between commit c9a5eccac1ab and the merge of the Hyper-V synthetic interrupt patches, and the latter was not adjusted. Paolo > We can still introduce this later if we ever need it. Or do you have a > concrete user in mind? > > The patch in general looks good to me. Just wondering if we can't simply > rip out that single function. >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic Paolo Bonzini <pbonzini@redhat.com> - 2016-11-17 18:10 +0100
Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic David Hildenbrand <david@redhat.com> - 2016-11-18 19:30 +0100
Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic David Hildenbrand <david@redhat.com> - 2016-11-18 20:30 +0100
Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic Paolo Bonzini <pbonzini@redhat.com> - 2016-11-18 20:30 +0100
Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic Radim Krčmář <rkrcmar@redhat.com> - 2016-11-19 20:40 +0100
csiph-web