Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1525672

Re: [PATCH v3 0/2] DW DMAC: update device tree

Show all headers | View raw

On Fri, 2016-11-18 at 22:12 +0300, Eugeniy Paltsev wrote:
> It wasn't possible to enable some features like
> memory-to-memory transfers or multi block transfers via DT.
> It is fixed by these patches.

First of all, please, give time to reviewers to comment the patches.
Usually it should be at least 24h (for the series that has been sent
first time 1 week approximately).

> 
> Changes for v3:
>  * Update existing platform data.
>    We don't need to update existing DTS because default logic 
>    wasn't change: we don't set "is_nollp" if we read 
>    configuration from DT before. And we don't set it now if
>    "multi-block" property doesn't exist in DTS.

See my comments in the patches.
And do not send the updated version earlier than Monday, please.

> 
> Changes for v2:
>  * I thought about is_memcpy DT property: all known devices, which 
>    use DT for configuration, support memory-to-memory transfers. 
>    So we don't need to read it from DT. So enable it by default, 
>    if we read configuration from DT.
> 
>  * Use "multi-block" instead of "hw-llp" name to be more clear.
> 
>  * Move adding DT property and adding documentation for this
>    property to one patch.
> 
> Eugeniy Paltsev (2):
>   DW DMAC: enable memory-to-memory transfers support
>   DW DMAC: add multi-block property to device tree
> 
>  Documentation/devicetree/bindings/dma/snps-dma.txt |  2 ++
>  drivers/dma/dw/core.c                              |  2 +-
>  drivers/dma/dw/platform.c                          | 11 +++++++++++
>  drivers/tty/serial/8250/8250_lpss.c                |  2 +-
>  include/linux/platform_data/dma-dw.h               |  4 ++--
>  5 files changed, 17 insertions(+), 4 deletions(-)
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/2] DW DMAC: update device tree Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-11-18 20:20 +0100
  [PATCH v3 1/2] DW DMAC: enable memory-to-memory transfers support Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-11-18 20:20 +0100
    Re: [PATCH v3 1/2] DW DMAC: enable memory-to-memory transfers  support Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-18 20:30 +0100
  Re: [PATCH v3 0/2] DW DMAC: update device tree Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-18 20:30 +0100
    Re: [PATCH v3 0/2] DW DMAC: update device tree Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-11-21 11:10 +0100
      Re: [PATCH v3 0/2] DW DMAC: update device tree Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-21 11:40 +0100
        Re: [PATCH v3 0/2] DW DMAC: update device tree Vinod Koul <vinod.koul@intel.com> - 2016-11-23 05:00 +0100

csiph-web