Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1525634

Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible

Show all headers | View raw

On Fri, Nov 18, 2016 at 11:46:23AM -0600, Josh Poimboeuf wrote:
> NMI stack dumps are bracked by the following tags:
> 
>   <NMI>
>   ...
>   <EOE>
> 
> The ending tag is kind of confusing if you don't already know what "EOE"
> means (end of exception).  The same ending tag is also used to mark the
> end of all other exceptions' stacks.  For example:
> 
>   <#DF>
>   ...
>   <EOE>
> 
> And similarly, "EOI" is used as the ending tag for interrupts:
> 
>   <IRQ>
>   ...
>   <EOI>
> 
> Change the tags to be more comprehensible by making them symmetrical and
> more XML-esque:
> 
>   <NMI>
>   ...
>   </NMI>
> 
>   <#DF>
>   ...
>   </#DF>
> 
>   <IRQ>
>   ...
>   </IRQ>
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

>  arch/x86/include/asm/stacktrace.h |  3 +--
>  arch/x86/kernel/dumpstack.c       | 12 ++++++------
>  arch/x86/kernel/dumpstack_32.c    | 19 ++++++++-----------
>  arch/x86/kernel/dumpstack_64.c    | 22 ++++++++--------------
>  4 files changed, 23 insertions(+), 33 deletions(-)

And saves lines too, awesome!

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/dumpstack: make stack name tags more comprehensible Josh Poimboeuf <jpoimboe@redhat.com> - 2016-11-18 18:50 +0100
  Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible Peter Zijlstra <peterz@infradead.org> - 2016-11-18 20:00 +0100
  Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible Frederic Weisbecker <fweisbec@gmail.com> - 2016-11-19 16:50 +0100
  Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible Josh Poimboeuf <jpoimboe@redhat.com> - 2016-11-19 21:30 +0100
  [tip:x86/asm] x86/dumpstack: Make stack name tags more  comprehensible tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2016-11-21 11:40 +0100
  [tip:x86/asm] x86/dumpstack: Make stack name tags more  comprehensible tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2016-11-21 13:10 +0100

csiph-web