Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1525620

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Show all headers | View raw

On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote:

> Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> > The correct include file for getting errno constants and ERR_PTR() is
> > linux/err.h, rather than linux/errno.h, so fix the include.
> > 
> > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state")
> > Acked-by: Andy Gross <andy.gross@linaro.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> 
> For some reason this fails to compile now. Can you take a look, please?
> 
> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> 5 patches set to Changes Requested.
> 
> 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
> 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client

This patch was updated with the necessary depends in Kconfig to catch
this exact issue and when I pull in your .config (which has QCOM_SMD=n,
QCOM_WCNSS_CTRL=n and WCN36XX=y) I can build this just fine.

I've tested the various combinations and it seems to work fine. Do you
have any other patches in your tree? Any stale objects?

Would you mind retesting this, before I invest more time in trying to
reproduce the issue you're seeing?

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-11-15 07:10 +0100
  [PATCH v5 4/5] wcn36xx: Implement print_reg indication Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-11-15 07:10 +0100
  [PATCH v5 2/5] wcn36xx: Transition driver to SMD client Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-11-15 07:10 +0100
  [PATCH v5 3/5] wcn36xx: Implement firmware assisted scan Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-11-15 07:10 +0100
  Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Kalle Valo <kvalo@qca.qualcomm.com> - 2016-11-16 19:50 +0100
    Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-11-18 19:40 +0100
      Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-11-22 16:00 +0100

csiph-web