Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1525463

Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

Show all headers | View raw

Hi Rahul,
Thanks for the patch.
Now looks great.

On Fri, Nov 18, 2016 at 08:45:25PM +0530, Rahul Krishnan wrote:
>This patch fixes the following checkpath.pl warning
>WARNING: braces {} are not necessary for single statement blocks
>
>
>Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>

Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>

>---
> drivers/staging/greybus/sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
>index 5649ef1..66b37ea 100644
>--- a/drivers/staging/greybus/sdio.c
>+++ b/drivers/staging/greybus/sdio.c
>@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
> 		state_changed = 1;
> 	}
>
>-	if (event & GB_SDIO_WP) {
>+	if (event & GB_SDIO_WP)
> 		host->read_only = true;
>-	}
>
> 	if (state_changed) {
> 		dev_info(mmc_dev(host->mmc), "card %s now event\n",
>-- 
>2.10.2
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH]: staging: Greybus: Remove unnecessary braces for single  statement block Rahul Krishnan <mrahul.krishnan@gmail.com> - 2016-11-18 16:20 +0100
  Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single  statement block Rui Miguel Silva <rmfrfs@gmail.com> - 2016-11-18 16:40 +0100
  Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single  statement block Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-21 05:10 +0100

csiph-web