Re: [patch] mmc: mmc_test: Uninitialized return value

From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [patch] mmc: mmc_test: Uninitialized return value
Date	2016-11-18 15:30 +0100
Message-ID	<sESkW-8jW-37@gated-at.bofh.it> (permalink)
References	<sDnMe-6mY-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 14 November 2016 at 12:31, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We never set "ret" to RESULT_OK.
>
> Fixes: 9f9c4180f88d ("mmc: mmc_test: add test for non-blocking transfers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied for next!

Kind regards
Uffe

>
> diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
> index f61c812..5ba6d77 100644
> --- a/drivers/mmc/card/mmc_test.c
> +++ b/drivers/mmc/card/mmc_test.c
> @@ -832,7 +832,7 @@ static int mmc_test_nonblock_transfer(struct mmc_test_card *test,
>         struct mmc_async_req *other_areq = &test_areq[1].areq;
>         enum mmc_blk_status status;
>         int i;
> -       int ret;
> +       int ret = RESULT_OK;
>
>         test_areq[0].test = test;
>         test_areq[1].test = test;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] mmc: mmc_test: Uninitialized return value Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-14 12:40 +0100
  Re: [patch] mmc: mmc_test: Uninitialized return value Ulf Hansson <ulf.hansson@linaro.org> - 2016-11-18 15:30 +0100

csiph-web