Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1525313
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions |
| Date | 2016-11-18 14:30 +0100 |
| Message-ID | <sERoS-7Cf-17@gated-at.bofh.it> (permalink) |
| References | <sEaae-4Bb-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Nov 16, 2016 at 04:14:27PM +0100, Arnd Bergmann wrote: > These two macros cause lots of warnings with gcc-7: > > drivers/scsi/bfa/bfa_svc.c: In function 'bfa_fcxp_meminfo': > drivers/scsi/bfa/bfa_svc.c:521:103: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context] > > Using inline functions makes them much more readable and avoids > the warnings. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Looks good, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions Arnd Bergmann <arnd@arndb.de> - 2016-11-16 16:20 +0100
Re: [PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions Johannes Thumshirn <jthumshirn@suse.de> - 2016-11-18 14:30 +0100
RE: [PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions "Gurumurthy, Anil" <Anil.Gurumurthy@cavium.com> - 2016-11-21 06:20 +0100
Re: [PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-11-22 04:30 +0100
csiph-web