Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1525266
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/5] i2c: designware: Master mode as separated driver |
| Date | 2016-11-18 13:40 +0100 |
| Message-ID | <sEQCu-75C-31@gated-at.bofh.it> (permalink) |
| References | <sEPwJ-6s7-5@gated-at.bofh.it> <sEPwL-6s7-53@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Fri, 2016-11-18 at 11:19 +0000, Luis Oliveira wrote: > - The functions related to I2C master mode of operation were > transformed in a single driver. > - The name of the i2c-designware-core.c had to be changed to i2c- > designware-src.c to for the cmake to be able to correctly compile both > modules into one > - Common definitions were moved to i2c-designware-core.h > drivers/i2c/busses/i2c-designware-src.c | 252 > +++++++++++++++ Perhaps i2c-designware-common.c ? > @@ -21,8 +21,6 @@ > * ------------------------------------------------------------------ > ---------- > * > */ > - > - No need to do that in this patch. > #define DW_IC_CON_MASTER 0x1 > #define DW_IC_CON_SPEED_STD 0x2 > #define DW_IC_CON_SPEED_FAST 0x4 > @@ -32,6 +30,123 @@ > #define DW_IC_CON_RESTART_EN 0x20 > #define DW_IC_CON_SLAVE_DISABLE 0x40 > > +/* > + * Registers offset > + */ > +#define DW_IC_CON 0x0 Okay, can we split this to move definitions and the rest? -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v3 0/5] i2c: designware: Add slave support Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-11-18 12:30 +0100
[PATCH v3 1/5] i2c: designware: Refactoring of the i2c-designware core and platform module Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-11-18 12:30 +0100
Re: [PATCH v3 1/5] i2c: designware: Refactoring of the i2c-designware core and platform module Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-18 13:30 +0100
[PATCH v3 2/5] i2c: designware: Master mode as separated driver Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-11-18 12:30 +0100
Re: [PATCH v3 2/5] i2c: designware: Master mode as separated driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-18 13:40 +0100
csiph-web