Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1525179

Re: [PATCH RFC 5/6] selftests: add EXTRA_CLEAN for clean target

Show all headers | View raw

bamvor.zhangjian@huawei.com writes:

> From: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
>
> Some testcases need the clean extra data after running. This patch
> introduce the "EXTRA_CLEAN" variable to address this requirement.

The idea here is fine I think. But this will need reworking if you
follow my suggestions for patch 1.

> After KOUTPUT_BUILD is enabled in later patch, it will be easy to
> decide to if we need do the cleanup in the KOUTPUT_BUILD path, if the
> testcase ran immediately after compiled.
>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>

All of these:

>  tools/testing/selftests/powerpc/benchmarks/Makefile   |  5 ++---
>  tools/testing/selftests/powerpc/copyloops/Makefile    |  3 +--
>  tools/testing/selftests/powerpc/dscr/Makefile         |  4 ++--
>  tools/testing/selftests/powerpc/math/Makefile         |  5 ++---
>  tools/testing/selftests/powerpc/primitives/Makefile   |  5 ++---
>  tools/testing/selftests/powerpc/stringloops/Makefile  |  5 ++---
>  tools/testing/selftests/powerpc/syscalls/Makefile     |  5 ++---
>  tools/testing/selftests/powerpc/tm/Makefile           |  5 ++---

are just cleaning *.o, and I'm pretty sure none of them need to. So for
those you can just drop the custom clean rule.

This one does need a custom rule:

>  .../testing/selftests/powerpc/switch_endian/Makefile  |  5 ++---


cheers

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH RFC 5/6] selftests: add EXTRA_CLEAN for clean target Michael Ellerman <mpe@ellerman.id.au> - 2016-11-18 12:10 +0100
  Re: [PATCH RFC 5/6] selftests: add EXTRA_CLEAN for clean target "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> - 2016-11-18 14:00 +0100

csiph-web