Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1524963

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

From Dan Williams <dan.j.williams@intel.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH] scsi: libsas: fix WARN on device removal
Date 2016-11-18 03:00 +0100
Message-ID <sEGD7-jQ-3@gated-at.bofh.it> (permalink)
References (5 earlier) <sBWbo-5Fm-31@gated-at.bofh.it> <sCfnH-1SI-9@gated-at.bofh.it> <sCfnI-1SI-19@gated-at.bofh.it> <sCfQJ-22L-15@gated-at.bofh.it> <sEyPh-3IB-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Nov 17, 2016 at 7:23 AM, John Garry <john.garry@huawei.com> wrote:
> On 11/11/2016 08:49, wangyijing wrote:
>>>>>
>>>>> I have not seen the flutter issue. I am just trying to solve the
>>>>> horrible WARN dump.
>>>>> However I do understand that there may be a issue related to how we
>>>>> queue the events; there was a recent attempt to fix this, but it came to
>>>>> nothing:
>>>>> https://www.spinics.net/lists/linux-scsi/msg99991.html
>>>>
>>>>
>>>> We found libsas hotplug several problems:
>>>> 1. sysfs warning calltrace(like the case you found);
>>>
>>>
>>> Maybe you can then review my patch.
>>
>>
>> I did it, I think your solution to fix the sysfs calltrace issue is ok,
>> and what I worried about is we still need to fix
>> the rest issues. So it's better if we could fix all issues one time.
>>
>
> @Maintainers, would you be willing to accept this patch as an interim fix
> for the dastardly WARN while we try to fix the flutter issue?

To me this adds a bug to quiet a benign, albeit noisy, warning.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal John Garry <john.garry@huawei.com> - 2016-11-17 18:40 +0100
  Re: [RFC PATCH] scsi: libsas: fix WARN on device removal Dan Williams <dan.j.williams@intel.com> - 2016-11-18 03:00 +0100
    Re: [RFC PATCH] scsi: libsas: fix WARN on device removal John Garry <john.garry@huawei.com> - 2016-11-18 10:10 +0100
      Re: [RFC PATCH] scsi: libsas: fix WARN on device removal Dan Williams <dan.j.williams@intel.com> - 2016-11-18 20:10 +0100
        Re: [RFC PATCH] scsi: libsas: fix WARN on device removal John Garry <john.garry@huawei.com> - 2016-11-21 16:20 +0100
          Re: [RFC PATCH] scsi: libsas: fix WARN on device removal Dan Williams <dan.j.williams@intel.com> - 2016-11-21 18:20 +0100
            Re: [RFC PATCH] scsi: libsas: fix WARN on device removal John Garry <john.garry@huawei.com> - 2016-11-22 18:00 +0100
              Re: [RFC PATCH] scsi: libsas: fix WARN on device removal wangyijing <wangyijing@huawei.com> - 2016-11-23 02:20 +0100
  Re: [RFC PATCH] scsi: libsas: fix WARN on device removal "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-11-18 03:00 +0100

csiph-web