Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1524781
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] sound: Add dependency on DMA |
| Date | 2016-11-17 20:50 +0100 |
| Message-ID | <sEAR4-4ZO-35@gated-at.bofh.it> (permalink) |
| References | <sEA4F-4sG-5@gated-at.bofh.it> <sEAem-4Lb-29@gated-at.bofh.it> <sEAo2-4ON-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/17/2016 11:14 AM, Florian Fainelli wrote: > On 11/17/2016 11:03 AM, Takashi Iwai wrote: >> On Thu, 17 Nov 2016 19:52:37 +0100, >> Florian Fainelli wrote: >>> >>> Architectures like m32r do not have a proper DMA-API implementation, >>> fixes COMPILE_TEST linking failures for the sounds subsystem. >> >> What error did you get exactly? >> There are already CONFIG_HAS_DMA dependency in a few places, so I >> wonder what's missing. > > They looked like these: > > sound/built-in.o: In function `snd_pcm_lib_default_mmap': > (.text+0xbb14): undefined reference to `bad_dma_ops' > sound/built-in.o: In function `snd_pcm_lib_default_mmap': > (.text+0xbb1c): undefined reference to `bad_dma_ops' > sound/built-in.o: In function `snd_pcm_lib_default_mmap': > (.text+0xbb34): undefined reference to `dma_common_mmap' > sound/built-in.o: In function `snd_pcm_lib_default_mmap': > (.text+0xbb34): relocation truncated to fit: R_M32R_26_PCREL_RELA > against undefined symbol `dma_common_mmap' > Makefile:961: recipe for target 'vmlinux' failed > > I could probably add an ifdef CONFIG_HAS_DMA just surrounding these > snd_pcm_lib if you think this is more appropriate? I can't reproduce this build failure reliably anyway now, it was due to switching between x86/m32r configurations, the only offender was the Broadcom Cygnus driver, and this has been fixed as well. Sorry for the noise! -- Florian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] sound: Add dependency on DMA Florian Fainelli <f.fainelli@gmail.com> - 2016-11-17 20:00 +0100
Re: [PATCH] sound: Add dependency on DMA Takashi Iwai <tiwai@suse.de> - 2016-11-17 20:10 +0100
Re: [PATCH] sound: Add dependency on DMA Florian Fainelli <f.fainelli@gmail.com> - 2016-11-17 20:20 +0100
Re: [PATCH] sound: Add dependency on DMA Florian Fainelli <f.fainelli@gmail.com> - 2016-11-17 20:50 +0100
Re: [PATCH] sound: Add dependency on DMA Takashi Iwai <tiwai@suse.de> - 2016-11-18 09:20 +0100
csiph-web