Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1523387

Re: [PATHCv10 1/2] usb: USB Type-C connector class

Show all headers | View raw

On Wed, Nov 16, 2016 at 10:49:49AM +0100, Greg KH wrote:
> On Wed, Nov 16, 2016 at 11:30:35AM +0200, Heikki Krogerus wrote:
> > On Tue, Nov 15, 2016 at 04:19:10PM -0800, Badhri Jagan Sridharan wrote:
> > > Hi,
> > > 
> > > At present I am using the uevent in the userspace to infer
> > > the Presence of a port on the remote end through the
> > > appearance of usbc*-partner.
> > > 
> > > Userspace uses this info to decide on when to show a USB
> > > notification on the screen and what should be the options
> > > provided in the dialog.
> > > 
> > > I was assuming that this is not something that would be dropped.
> > > 
> > > Coding using events was relatively easier to program from userspace ..
> > > 
> > > Is it possible to use POLL for identifying the appearance of port partner ?
> > > I did not notice sysfs_notify call in typec_connect/typec_disconnect.
> > > 
> > > It would also be nice to have uevent notifications when the contents
> > > of current_data_role or current_power_role changes.
> > > 
> > > Is that too costly to have ?
> > 
> > Greg, could you give your opinion. In this case we do have attribute
> > files that the user space can poll. Data role is the USB data role, so
> > host or device, and it can change for example if the partner executes
> > a swap. The same can happen with the power role.
> 
> So the same 'struct device' switches roles and attribute files are
> updated that need to be re-read?  If so, yes KOBJ_CHANGE is correct, if
> a struct device is added/removed for this, then no, it doesn't make
> sense.

OK, I'll add KOBJ_CHANGE for those.

So is it OK to everybody if I remove the KOBJ_CHANGE in
typec_connect()? We will see uevent KOBJ_ADD since the partner (or
cable) is added in any case. Badhri, Oliver?


Thanks,

-- 
heikki

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATHCv10 1/2] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-14 11:00 +0100
  Re: [PATHCv10 1/2] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-14 13:40 +0100
    Re: [PATHCv10 1/2] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-14 15:20 +0100
      Re: [PATHCv10 1/2] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-14 15:40 +0100
        Re: [PATHCv10 1/2] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-14 16:10 +0100
    Re: [PATHCv10 1/2] usb: USB Type-C connector class Guenter Roeck <linux@roeck-us.net> - 2016-11-14 15:40 +0100
      Re: [PATHCv10 1/2] usb: USB Type-C connector class Oliver Neukum <oneukum@suse.com> - 2016-11-16 10:00 +0100
    Re: [PATHCv10 1/2] usb: USB Type-C connector class Guenter Roeck <linux@roeck-us.net> - 2016-11-14 21:50 +0100
      Re: [PATHCv10 1/2] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-15 08:10 +0100
        Re: [PATHCv10 1/2] usb: USB Type-C connector class Guenter Roeck <linux@roeck-us.net> - 2016-11-15 10:30 +0100
          Re: [PATHCv10 1/2] usb: USB Type-C connector class Badhri Jagan Sridharan <badhri@google.com> - 2016-11-16 01:20 +0100
            Re: [PATHCv10 1/2] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-16 10:40 +0100
              Re: [PATHCv10 1/2] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-16 10:50 +0100
                Re: [PATHCv10 1/2] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-16 12:20 +0100
                Re: [PATHCv10 1/2] usb: USB Type-C connector class Oliver Neukum <oneukum@suse.com> - 2016-11-16 12:40 +0100
                Re: [PATHCv10 1/2] usb: USB Type-C connector class Badhri Jagan Sridharan <badhri@google.com> - 2016-11-16 15:40 +0100
                Re: [PATHCv10 1/2] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-16 15:50 +0100
              Re: [PATHCv10 1/2] usb: USB Type-C connector class Oliver Neukum <oneukum@suse.com> - 2016-11-16 10:50 +0100
  Re: [PATHCv10 1/2] usb: USB Type-C connector class Badhri Jagan Sridharan <badhri@google.com> - 2016-11-16 16:30 +0100
  Re: [PATHCv10 1/2] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-16 16:30 +0100
    Re: [PATHCv10 1/2] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-16 16:40 +0100
      Re: [PATHCv10 1/2] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-17 09:30 +0100

csiph-web