Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522156

Re: [PATCH 2/2] usb: dwc2: fixes host_dma logic

Show all headers | View raw

On 11/11/2016 12:59 PM, Christian Lamparter wrote:
> This patch moves the the host_dma initialization
> before dwc2_set_param_dma_desc_enable and
> dwc2_set_param_dma_desc_fs_enable. The reason being
> that both function need it.
> 
> Fixes: 1205489cee75bf39 ("usb: dwc2: Get host DMA device properties")

This should probably be omitted since it's only in Felipe's
testing/next.

Otherwise looks good.

Acked-by: John Youn <johnyoun@synopsys.com>

Regards,
John


> 
> Cc: John Youn <johnyoun@synopsys.com>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
> ---
>  drivers/usb/dwc2/params.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 5d822c5..222a83c 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -1157,9 +1157,6 @@ static void dwc2_set_parameters(struct dwc2_hsotg *hsotg,
>  	bool dma_capable = !(hw->arch == GHWCFG2_SLAVE_ONLY_ARCH);
>  
>  	dwc2_set_param_otg_cap(hsotg, params->otg_cap);
> -	dwc2_set_param_dma_desc_enable(hsotg, params->dma_desc_enable);
> -	dwc2_set_param_dma_desc_fs_enable(hsotg, params->dma_desc_fs_enable);
> -
>  	if ((hsotg->dr_mode == USB_DR_MODE_HOST) ||
>  	    (hsotg->dr_mode == USB_DR_MODE_OTG)) {
>  		bool disable;
> @@ -1174,6 +1171,8 @@ static void dwc2_set_parameters(struct dwc2_hsotg *hsotg,
>  				    !disable, false,
>  				    dma_capable);
>  	}
> +	dwc2_set_param_dma_desc_enable(hsotg, params->dma_desc_enable);
> +	dwc2_set_param_dma_desc_fs_enable(hsotg, params->dma_desc_fs_enable);
>  
>  	dwc2_set_param_host_support_fs_ls_low_power(hsotg,
>  			params->host_support_fs_ls_low_power);
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] usb: dwc2: add amcc,dwc-otg support Christian Lamparter <chunkeey@googlemail.com> - 2016-11-11 22:00 +0100
  [PATCH 2/2] usb: dwc2: fixes host_dma logic Christian Lamparter <chunkeey@googlemail.com> - 2016-11-11 22:00 +0100
    Re: [PATCH 2/2] usb: dwc2: fixes host_dma logic John Youn <John.Youn@synopsys.com> - 2016-11-15 00:00 +0100
  Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support John Youn <John.Youn@synopsys.com> - 2016-11-11 22:30 +0100
    Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support Christian Lamparter <chunkeey@googlemail.com> - 2016-11-11 23:10 +0100
      Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support John Youn <John.Youn@synopsys.com> - 2016-11-11 23:30 +0100
        Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support Christian Lamparter <chunkeey@googlemail.com> - 2016-11-12 00:20 +0100
          Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support John Youn <John.Youn@synopsys.com> - 2016-11-15 00:10 +0100
            Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support John Youn <John.Youn@synopsys.com> - 2016-11-15 20:10 +0100
              Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-11-16 10:30 +0100

csiph-web