Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522095

Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

From Florian Fainelli <f.fainelli@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed
Date 2016-11-14 22:30 +0100
Message-ID <sDwZb-3Wk-9@gated-at.bofh.it> (permalink)
References <sCQdA-BP-5@gated-at.bofh.it> <sDwPw-3SH-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 11/14/2016 01:18 PM, David Miller wrote:
> From: Alexandru Gagniuc <alex.g@adaptrum.com>
> Date: Sat, 12 Nov 2016 15:32:13 -0800
> 
>> +	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
>> +		ret = vsc8601_add_skew(phydev);
> 
> I think you should use phy_interface_is_rgmii() here.
> 

This would include all RGMII modes, here I think the intent is to check
for PHY_INTERFACE_MODE_RGMII_ID and PHY_INTERFACE_MODE_RGMII_TXID (or
RXID),  Alexandru, what direction does the skew settings apply to?
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed Alexandru Gagniuc <alex.g@adaptrum.com> - 2016-11-13 00:50 +0100
  Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if  needed David Miller <davem@davemloft.net> - 2016-11-14 22:20 +0100
    Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if  needed Florian Fainelli <f.fainelli@gmail.com> - 2016-11-14 22:30 +0100
      Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if  needed David Miller <davem@davemloft.net> - 2016-11-16 04:20 +0100
        Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if  needed Andrew Lunn <andrew@lunn.ch> - 2016-11-16 15:00 +0100
          Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if  needed Andrew Lunn <andrew@lunn.ch> - 2016-11-16 18:00 +0100
        Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601,  if needed David Miller <davem@davemloft.net> - 2016-11-17 00:00 +0100

csiph-web