Groups > linux.kernel > #1522059

Re: [RFC PATCH v3 06/20] x86: Add support to enable SME during early boot processing

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v3 06/20] x86: Add support to enable SME during early boot processing
Date	2016-11-14 21:10 +0100
Message-ID	<sDvJM-3eN-79@gated-at.bofh.it> (permalink)
References	<sBVfj-4HF-7@gated-at.bofh.it> <sDteW-1wp-41@gated-at.bofh.it> <sDteW-1wp-39@gated-at.bofh.it> <sDvJM-3eN-81@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 14, 2016 at 12:18:44PM -0600, Tom Lendacky wrote:
> The %rsi register can be clobbered by the called function so I'm saving
> it since it points to the real mode data.  I might be able to look into
> saving it earlier and restoring it before needed, but I though this
> might be clearer.

Ah, that's already in the comment earlier, I missed that.

> I can expand on the commit message about that.  I was trying to keep the
> early boot-related code separate from the main code in arch/x86/mm dir.

... because?

It all gets linked into one monolithic image anyway and mem_encrypt.c
is not, like, really huge, right? IOW, I don't see a reason to spread
the code around the tree. OTOH, having everything in one file is much
better.

Or am I missing a good reason?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v3 06/20] x86: Add support to enable SME during early  boot processing Borislav Petkov <bp@alien8.de> - 2016-11-14 18:30 +0100
  Re: [RFC PATCH v3 06/20] x86: Add support to enable SME during early  boot processing Borislav Petkov <bp@alien8.de> - 2016-11-14 21:10 +0100

csiph-web