Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1521980

[PATCH 01/11] mailbox: bcm-pdc: Use octal permissions rather than symbolic

From Rob Rice <rob.rice@broadcom.com>
Newsgroups linux.kernel
Subject [PATCH 01/11] mailbox: bcm-pdc: Use octal permissions rather than symbolic
Date 2016-11-14 19:40 +0100
Message-ID <sDukG-2cH-15@gated-at.bofh.it> (permalink)
References <sDuaZ-28T-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


When creating the debugfs files for the PDC driver, use
octal file permissions rather than symbolic file permissions.

Signed-off-by: Rob Rice <rob.rice@broadcom.com>
Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
---
 drivers/mailbox/bcm-pdc-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mailbox/bcm-pdc-mailbox.c b/drivers/mailbox/bcm-pdc-mailbox.c
index c19dd82..a9c804f 100644
--- a/drivers/mailbox/bcm-pdc-mailbox.c
+++ b/drivers/mailbox/bcm-pdc-mailbox.c
@@ -480,7 +480,8 @@ static void pdc_setup_debugfs(struct pdc_state *pdcs)
 	if (!debugfs_dir)
 		debugfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
 
-	pdcs->debugfs_stats = debugfs_create_file(spu_stats_name, S_IRUSR,
+	/* S_IRUSR == 0400 */
+	pdcs->debugfs_stats = debugfs_create_file(spu_stats_name, 0400,
 						  debugfs_dir, pdcs,
 						  &pdc_debugfs_stats);
 }
-- 
2.1.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 01/11] mailbox: bcm-pdc: Use octal permissions rather than symbolic Rob Rice <rob.rice@broadcom.com> - 2016-11-14 19:40 +0100

csiph-web