Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1521930
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mfd: bcm590xx: Simplify a test |
| Date | 2016-11-14 18:50 +0100 |
| Message-ID | <sDtyh-1DM-11@gated-at.bofh.it> (permalink) |
| References | <syBd7-5b8-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 01 Nov 2016, Christophe JAILLET wrote:
> 'i2c_new_dummy()' does not return an error pointer, so the test can be
> simplified to be more consistent.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/mfd/bcm590xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
> index 0d76d690176b..c572a35a9341 100644
> --- a/drivers/mfd/bcm590xx.c
> +++ b/drivers/mfd/bcm590xx.c
> @@ -67,7 +67,7 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c_pri,
> /* Secondary I2C slave address is the base address with A(2) asserted */
> bcm590xx->i2c_sec = i2c_new_dummy(i2c_pri->adapter,
> i2c_pri->addr | BIT(2));
> - if (IS_ERR_OR_NULL(bcm590xx->i2c_sec)) {
> + if (!bcm590xx->i2c_sec) {
> dev_err(&i2c_pri->dev, "failed to add secondary I2C device\n");
> return -ENODEV;
> }
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] mfd: bcm590xx: Simplify a test Lee Jones <lee.jones@linaro.org> - 2016-11-14 18:50 +0100
csiph-web