Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver
Date	2016-11-14 17:20 +0100
Message-ID	<sDs9b-RG-17@gated-at.bofh.it> (permalink)
References	(4 earlier) <sznhL-2zZ-19@gated-at.bofh.it> <sznB7-2Ga-3@gated-at.bofh.it> <sBFNh-2u3-55@gated-at.bofh.it> <sBShr-2x7-11@gated-at.bofh.it> <sBUsW-4g1-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 10, 2016 at 4:02 AM, Andi Shyti <andi.shyti@samsung.com> wrote:
> Hi Jacek,
>
>> > > > > Only DT bindings of LED class drivers should be placed in
>> > > > > Documentation/devicetree/bindings/leds. Please move it to the
>> > > > > media bindings.
>> > > >
>> > > > that's where I placed it first, but Rob asked me to put it in the
>> > > > LED directory and Cc the LED mailining list.
>> > > >
>> > > > That's the discussion of the version 2:
>> > > >
>> > > > https://lkml.org/lkml/2016/9/12/380
>> > > >
>> > > > Rob, Jacek, could you please agree where I can put the binding?
>> > >
>> > > I'm not sure if this is a good approach. I've noticed also that
>> > > backlight bindings have been moved to leds, whereas they don't look
>> > > similarly.
>> > >
>> > > We have common.txt LED bindings, that all LED class drivers' bindings
>> > > have to follow. Neither backlight bindings nor these ones do that,
>> > > which introduces some mess.
>> >
>> > And there are probably LED bindings that don't follow common.txt either.
>> >
>> > > Eventually adding a sub-directory, e.g. remote_control could make it
>> > > somehow logically justified, but still - shouldn't bindings be
>> > > placed in the documentation directory related to the subsystem of the
>> > > driver they are predestined to?
>> >
>> > No. While binding directories often mirror the driver directories, they
>> > are not the same. Bindings are grouped by types of h/w and IR LEDs are a
>> > type of LED.
>> >
>> > If you prefer a sub-dir, that is fine with me.
>>
>> Fine. So how about sub-dir "ir" ?
>
> would we put here all the remote control bindings that currently
> are under media?

No. Only if they are just an LED that happens to be IR.

Rob

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 5/6] Documentation: bindings: add documentation for  ir-spi device driver Rob Herring <robh@kernel.org> - 2016-11-14 17:20 +0100

csiph-web