Re: [PATCH 1/3] soc: sunxi: make sunxi_sram explicitly non-modular

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] soc: sunxi: make sunxi_sram explicitly non-modular
Date	2016-11-14 10:10 +0100
Message-ID	<sDlr4-4Yb-9@gated-at.bofh.it> (permalink)
References	<sDbi2-6pp-7@gated-at.bofh.it> <sDbrI-6t6-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, Nov 13, 2016 at 02:03:00PM -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/soc/sunxi/Kconfig:config SUNXI_SRAM
> drivers/soc/sunxi/Kconfig:      bool
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] soc: avoid module usage in non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-11-13 23:30 +0100
  [PATCH 3/3] soc: fsl: make guts driver explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-11-13 23:30 +0100
    Re: [PATCH 3/3] soc: fsl: make guts driver explicitly non-modular Scott Wood <oss@buserror.net> - 2016-11-15 06:20 +0100
  [PATCH 1/3] soc: sunxi: make sunxi_sram explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-11-13 23:30 +0100
    Re: [PATCH 1/3] soc: sunxi: make sunxi_sram explicitly non-modular Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-14 10:10 +0100

csiph-web