Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1521453
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | William Wu <wulf@rock-chips.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time |
| Date | Mon, 14 Nov 2016 10:40:02 +0100 |
| Message-ID | <sDlU6-58t-3@gated-at.bofh.it> (permalink) |
| References | <sDlKp-55b-13@gated-at.bofh.it> |
| X-Original-To | kishon@ti.com, heiko@sntech.de |
| X-263anti-Spam | KSV:0; |
| X-Mail-Delivery | 1 |
| X-Abs-Checked | 4 |
| X-Rl-Sender | wulf@rock-chips.com |
| X-Fst-To | kishon@ti.com |
| X-Sender-IP | 58.22.7.114 |
| X-Login-Name | wulf@rock-chips.com |
| X-Unique-Tag | <2af08be38277aea13a67b56e0192b51c> |
| X-Sender | wulf@rock-chips.com |
| X-Mailer | git-send-email 2.0.0 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, frank.wang@rock-chips.com, huangtao@rock-chips.com, dianders@google.com, briannorris@google.com, groeck@google.com, wulf@rock-chips.com |
| X-Original-Date | Mon, 14 Nov 2016 17:27:11 +0800 |
| X-Original-Message-ID | <1479115631-20137-3-git-send-email-wulf@rock-chips.com> |
| X-Original-References | <1479115631-20137-1-git-send-email-wulf@rock-chips.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1521453 |
Show key headers only | View raw
We found that the system crashed due to 480MHz output clock of
USB2 PHY was unstable after clock had been enabled by gpu module.
Theoretically, 1 millisecond is a critical value for 480MHz
output clock stable time, so we try to change the delay time
to 1.2 millisecond to avoid this issue.
And the commit ed907fb1d7c3 ("phy: rockchip-inno-usb2: correct
clk_ops callback") used prepare callbacks instead of enable
callbacks to support gate a clk if the operation may sleep. So
we can switch from delay to sleep functions.
Signed-off-by: William Wu <wulf@rock-chips.com>
---
Changes in v3:
- fix kbuild test error: too few arguments to function 'usleep_range'
Changes in v2:
- use usleep_range() function instead of mdelay()
drivers/phy/phy-rockchip-inno-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c
index 365e077..0e52b25 100644
--- a/drivers/phy/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/phy-rockchip-inno-usb2.c
@@ -166,7 +166,7 @@ static int rockchip_usb2phy_clk480m_prepare(struct clk_hw *hw)
return ret;
/* waitting for the clk become stable */
- mdelay(1);
+ usleep_range(1200, 1300);
}
return 0;
--
2.0.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/2] phy: rockchip-inno-usb2: correct 480MHz clk_ops callbacks and stable time William Wu <wulf@rock-chips.com> - 2016-11-14 10:30 +0100
[PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time William Wu <wulf@rock-chips.com> - 2016-11-14 10:40 +0100
Re: [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time Doug Anderson <dianders@google.com> - 2016-11-14 19:20 +0100
Re: [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time wlf <wulf@rock-chips.com> - 2016-11-15 04:30 +0100
[PATCH v3 1/2] phy: rockchip-inno-usb2: correct clk_ops callback William Wu <wulf@rock-chips.com> - 2016-11-14 10:40 +0100
csiph-web