Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1523041

Re: [PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops

Show all headers | View raw

Hi Kees,

On Fri, Nov 11, 2016 at 2:21 PM, Kees Cook <keescook@chromium.org> wrote:
> Hi Joel,
>
> I've reorganized a bunch of the logic here. Since pstore is going to need
> the init_przs() logic for multiple pmsg przs, I wanted to get this in and
> make sure I was happy with how it looks. I figured this would reduce our
> round-trip time on reviews. :)
>
> Can you test this series and verify that it works as you're expecting? I've
> validated some basic behavior already, but don't have a good test-case for
> ftrace. What commands do you actually use for testing ftrace? I'd like to
> add something to my local tests.

I normally do the following:

dd if=/dev/urandom | pv | dd of=/dev/null

and in parallel, I do a:
echo 1 > /sys/kernel/debug/pstore/record_ftrace

and then check the throughput; and then reboot the system and do a
read out of /sys/fs/pstore/ ftrace file.

I will try these patches out today and thanks for refactoring the init
prz stuff.

Regards,
Joel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops Kees Cook <keescook@chromium.org> - 2016-11-11 23:30 +0100
  [PATCH v3 6/8] pstore: Add ftrace timestamp counter Kees Cook <keescook@chromium.org> - 2016-11-11 23:30 +0100
  [PATCH v3 8/8] pstore: improve error report for failed setup Kees Cook <keescook@chromium.org> - 2016-11-11 23:40 +0100
  Re: [PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops Joel Fernandes <joelaf@google.com> - 2016-11-15 21:00 +0100
    Re: [PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops Kees Cook <keescook@chromium.org> - 2016-11-15 22:40 +0100
      Re: [PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops Joel Fernandes <joelaf@google.com> - 2016-11-15 23:10 +0100
        Re: [PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops Kees Cook <keescook@chromium.org> - 2016-11-15 23:20 +0100
          Re: [PATCH v3 0/8] pstore: Improve performance of ftrace backend with ramoops Joel Fernandes <joelaf@google.com> - 2016-11-16 07:40 +0100

csiph-web